This is an archive of the discontinued LLVM Phabricator instance.

Use configure depends to trigger reconfiguration when LLVMBuild files change
ClosedPublic

Authored by danielframpton on May 19 2020, 8:42 AM.

Details

Summary

The existing logic has a workaround where configure_file is used to write a single dummy file output many times.

CMake has a feature to more directly add the dependency and avoid the dummy file (it is available in the minimum version specified).

Diff Detail

Event Timeline

danielframpton created this revision.May 19 2020, 8:42 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 19 2020, 8:42 AM
theraven accepted this revision.May 19 2020, 10:22 AM
theraven added a subscriber: theraven.

Looks good to me. I presume we didn't use this because of CMake version dependencies. Was this feature available in our current minimum CMake version?

This revision is now accepted and ready to land.May 19 2020, 10:22 AM

Looks good to me. I presume we didn't use this because of CMake version dependencies. Was this feature available in our current minimum CMake version?

It was added in CMake 3.0.0, and we currently require 3.4.3.

The code I am changing here dates from 2011.

That makes sense. Do you have commit access yet? If not, I'll merge this tomorrow.

This seems to be failing on the Windows pre-merge test run. Unfortunately, I don't have access to those logs and so I can't merge this until this issue is fixed: https://github.com/google/llvm-premerge-checks/issues/187

This revision was automatically updated to reflect the committed changes.