Page MenuHomePhabricator

Improve MiStackTestCase tests
ClosedPublic

Authored by ki.stfu on Mar 2 2015, 7:17 AM.

Diff Detail

Event Timeline

ki.stfu updated this revision to Diff 21005.Mar 2 2015, 7:17 AM
ki.stfu retitled this revision from to Improve MiStackTestCase tests.
ki.stfu updated this object.
ki.stfu edited the test plan for this revision. (Show Details)
ki.stfu added reviewers: abidh, clayborg.
ki.stfu added subscribers: abidh, clayborg, Unknown Object (MLST).
ki.stfu updated this revision to Diff 21006.Mar 2 2015, 7:22 AM

Skip test_lldbmi_stack_info_frame unless Darwin

clayborg accepted this revision.Mar 2 2015, 10:53 AM
clayborg edited edge metadata.
This revision is now accepted and ready to land.Mar 2 2015, 10:53 AM
abidh edited edge metadata.Mar 2 2015, 8:02 PM

Hi,
I am travelling and will not be able to review your patch this week. If
there are problems in tests on Linux, please disable them on Linux before
committing. I will fix/enable them when I am back in office.

Thanks,
Abid

ki.stfu closed this revision.Mar 3 2015, 7:19 AM
In D8004#133209, @abidh wrote:

Hi,
I am travelling and will not be able to review your patch this week. If
there are problems in tests on Linux, please disable them on Linux before
committing. I will fix/enable them when I am back in office.

Thanks,
Abid

Ok. Thanks for information. I disabled this test because it was tested only on OS X.

test/tools/lldb-mi/stack/TestMiStack.py
218

works for darwin