This is an archive of the discontinued LLVM Phabricator instance.

Differential D8003

[llgo] Disable known failing packages in check-libgo
ClosedPublic

Authored by axw on Mar 2 2015, 7:10 AM.

Details

Reviewers
pcc
Commits
rGd07b2b42285e: [llgo] Disable known failing packages in check-libgo
rL231448: [llgo] Disable known failing packages in check-libgo
Summary

There are two packages in libgo which have
known failures when running the "make check" rule.
This change disables those packages in the tests so
that we can run libgo tests without them until the
root causes are identified and resolved.

Diff Detail

Event Timeline

axw updated this revision to Diff 21003.Mar 2 2015, 7:10 AM
axw retitled this revision from to [llgo] Disable known failing packages in check-libgo.
axw updated this object.
axw edited the test plan for this revision. (Show Details)
axw added a reviewer: pcc.
axw added a subscriber: Unknown Object (MLST).
pcc accepted this revision.Mar 5 2015, 12:27 PM
pcc edited edge metadata.

LGTM

This revision is now accepted and ready to land.Mar 5 2015, 12:27 PM
axw closed this revision.Mar 5 2015, 6:51 PM
Manna mentioned this in D59280: Allow 'static' storage specifier on an out-of-line class member template declaration in MSVCCompat mode.May 7 2019, 8:37 AM

Revision Contents

PathSize
40 lines
third_party/
gofrontend/
libgo/
2 lines
2 lines
2 lines

Diff 21003

libgo-check-failures.diff

  • This file was added.
diff --git a/libgo/Makefile.am b/libgo/Makefile.am
index 526b656..31c206e 100644
--- a/libgo/Makefile.am
+++ b/libgo/Makefile.am
@@ -3688,7 +3688,6 @@ TEST_PACKAGES = \
os/check \
path/check \
reflect/check \
- regexp/check \
runtime/check \
sort/check \
strconv/check \
@@ -3787,7 +3786,6 @@ TEST_PACKAGES = \
os/user/check \
path/filepath/check \
regexp/syntax/check \
- runtime/pprof/check \
sync/atomic/check \
text/scanner/check \
text/tabwriter/check \
diff --git a/libgo/Makefile.in b/libgo/Makefile.in
index 2254478..d2482d1 100644
--- a/libgo/Makefile.in
+++ b/libgo/Makefile.in
@@ -2193,7 +2193,6 @@ TEST_PACKAGES = \
os/check \
path/check \
reflect/check \
- regexp/check \
runtime/check \
sort/check \
strconv/check \
@@ -2292,7 +2291,6 @@ TEST_PACKAGES = \
os/user/check \
path/filepath/check \
regexp/syntax/check \
- runtime/pprof/check \
sync/atomic/check \
text/scanner/check \
text/tabwriter/check \

third_party/gofrontend/libgo/Makefile.am

Show First 20 Lines • Show All 3,682 Lines • ▼ Show 20 LinesTEST_PACKAGES = \
io/check \ io/check \
log/check \ log/check \
math/check \ math/check \
mime/check \ mime/check \
net/check \ net/check \
os/check \ os/check \
path/check \ path/check \
reflect/check \ reflect/check \
regexp/check \
runtime/check \ runtime/check \
sort/check \ sort/check \
strconv/check \ strconv/check \
strings/check \ strings/check \
sync/check \ sync/check \
syscall/check \ syscall/check \
time/check \ time/check \
unicode/check \ unicode/check \
▲ Show 20 Lines • Show All 82 Lines • ▼ Show 20 LinesTEST_PACKAGES = \
net/rpc/jsonrpc/check \ net/rpc/jsonrpc/check \
old/regexp/check \ old/regexp/check \
old/template/check \ old/template/check \
os/exec/check \ os/exec/check \
os/signal/check \ os/signal/check \
os/user/check \ os/user/check \
path/filepath/check \ path/filepath/check \
regexp/syntax/check \ regexp/syntax/check \
runtime/pprof/check \
sync/atomic/check \ sync/atomic/check \
text/scanner/check \ text/scanner/check \
text/tabwriter/check \ text/tabwriter/check \
text/template/check \ text/template/check \
text/template/parse/check \ text/template/parse/check \
testing/quick/check \ testing/quick/check \
unicode/utf16/check \ unicode/utf16/check \
unicode/utf8/check unicode/utf8/check
▲ Show 20 Lines • Show All 116 Lines • Show Last 20 Lines

third_party/gofrontend/libgo/Makefile.in

  • This file is larger than 256 KB, so syntax highlighting is disabled by default.
Show First 20 Lines • Show All 2,187 Lines • ▼ Show 20 LinesTEST_PACKAGES = \
io/check \ io/check \
log/check \ log/check \
math/check \ math/check \
mime/check \ mime/check \
net/check \ net/check \
os/check \ os/check \
path/check \ path/check \
reflect/check \ reflect/check \
regexp/check \
runtime/check \ runtime/check \
sort/check \ sort/check \
strconv/check \ strconv/check \
strings/check \ strings/check \
sync/check \ sync/check \
syscall/check \ syscall/check \
time/check \ time/check \
unicode/check \ unicode/check \
▲ Show 20 Lines • Show All 82 Lines • ▼ Show 20 LinesTEST_PACKAGES = \
net/rpc/jsonrpc/check \ net/rpc/jsonrpc/check \
old/regexp/check \ old/regexp/check \
old/template/check \ old/template/check \
os/exec/check \ os/exec/check \
os/signal/check \ os/signal/check \
os/user/check \ os/user/check \
path/filepath/check \ path/filepath/check \
regexp/syntax/check \ regexp/syntax/check \
runtime/pprof/check \
sync/atomic/check \ sync/atomic/check \
text/scanner/check \ text/scanner/check \
text/tabwriter/check \ text/tabwriter/check \
text/template/check \ text/template/check \
text/template/parse/check \ text/template/parse/check \
testing/quick/check \ testing/quick/check \
unicode/utf16/check \ unicode/utf16/check \
unicode/utf8/check unicode/utf8/check
▲ Show 20 Lines • Show All 3,815 Lines • Show Last 20 Lines

update_third_party.sh

Show All 19 Lines
hg clone -r $gofrontendrev $gofrontendrepo $gofrontenddir hg clone -r $gofrontendrev $gofrontendrepo $gofrontenddir
cp -r $gofrontenddir/LICENSE $gofrontenddir/libgo third_party/gofrontend cp -r $gofrontenddir/LICENSE $gofrontenddir/libgo third_party/gofrontend
# Apply a diff that eliminates use of the unnamed struct extension beyond what # Apply a diff that eliminates use of the unnamed struct extension beyond what
# -fms-extensions supports. # -fms-extensions supports.
(cd third_party/gofrontend && patch -p1) < libgo-noext.diff (cd third_party/gofrontend && patch -p1) < libgo-noext.diff
# Apply a diff that disables testing of packages known to fail.
(cd third_party/gofrontend && patch -p1) < libgo-check-failures.diff
find third_party/gofrontend -name '*.orig' -exec rm \{\} \; find third_party/gofrontend -name '*.orig' -exec rm \{\} \;
# Remove GPL licensed files. # Remove GPL licensed files.
rm \ rm \
third_party/gofrontend/libgo/testsuite/libgo.testmain/testmain.exp \ third_party/gofrontend/libgo/testsuite/libgo.testmain/testmain.exp \
third_party/gofrontend/libgo/testsuite/lib/libgo.exp \ third_party/gofrontend/libgo/testsuite/lib/libgo.exp \
third_party/gofrontend/libgo/testsuite/config/default.exp third_party/gofrontend/libgo/testsuite/config/default.exp
▲ Show 20 Lines • Show All 75 Lines • Show Last 20 Lines