Refactor: Move readability checks to namespace clang::tidy::readability

[LegalizeAdulthood]

Summary

clang-tidy checks are organized into modules. This refactoring moves the readability module checks into the namespace clang::tidy::readability

[alexfh]

Looks good!

Thanks for the patch. I'll commit it for you.

[alexfh]

Committed revision 230946.

clang-tidy/readability/ElseAfterReturnCheck.h

 //===--- ElseAfterReturnCheck.h - clang-tidy---------------------*- C++ -*-===//
 //
 //                     The LLVM Compiler Infrastructure
 //
 // This file is distributed under the University of Illinois Open Source
 // License. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
 
 #ifndef LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_READABILITY_ELSE_AFTER_RETURN_H
 #define LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_READABILITY_ELSE_AFTER_RETURN_H
 
 #include "../ClangTidy.h"
 
 namespace clang {
 namespace tidy {
+namespace readability {
 
 class ElseAfterReturnCheck : public ClangTidyCheck {
 public:
   ElseAfterReturnCheck(StringRef Name, ClangTidyContext *Context)
       : ClangTidyCheck(Name, Context) {}
   void registerMatchers(ast_matchers::MatchFinder *Finder) override;
   void check(const ast_matchers::MatchFinder::MatchResult &Result) override;
 };
 
+} // namespace readability
 } // namespace tidy
 } // namespace clang
 
 #endif // LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_READABILITY_ELSE_AFTER_RETURN_H
-

clang-tidy/readability/ElseAfterReturnCheck.cpp

 #include "ElseAfterReturnCheck.h"
 #include "clang/AST/ASTContext.h"
 #include "clang/ASTMatchers/ASTMatchFinder.h"
 
 using namespace clang::ast_matchers;
 
 namespace clang {
 namespace tidy {
+namespace readability {
 
 void ElseAfterReturnCheck::registerMatchers(MatchFinder *Finder) {
   // FIXME: Support continue, break and throw.
   Finder->addMatcher(
       ifStmt(
           hasThen(stmt(anyOf(returnStmt(), compoundStmt(has(returnStmt()))))),
           hasElse(stmt().bind("else"))).bind("if"),
       this);
void ElseAfterReturnCheck::check(const MatchFinder::MatchResult &Result) {
   Diag << removeToken(ElseLoc);
 
   // FIXME: Removing the braces isn't always safe. Do a more careful analysis.
   // FIXME: Change clang-format to correctly un-indent the code.
   if (const auto *CS = Result.Nodes.getNodeAs<CompoundStmt>("else"))
     Diag << removeToken(CS->getLBracLoc()) << removeToken(CS->getRBracLoc());
 }
 
+} // namespace readability
 } // namespace tidy
 } // namespace clang
-

clang-tidy/readability/ShrinkToFitCheck.h

 //===--- ShrinkToFitCheck.h - clang-tidy-------------------------*- C++ -*-===//
 //
 //                     The LLVM Compiler Infrastructure
 //
 // This file is distributed under the University of Illinois Open Source
 // License. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
 
 #ifndef LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_READABILITY_SHRINK_TO_FIT_H
 #define LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_READABILITY_SHRINK_TO_FIT_H
 
 #include "../ClangTidy.h"
 
 namespace clang {
 namespace tidy {
+namespace readability {
 
 /// \brief Replace copy and swap tricks on shrinkable containers with the
 /// \c shrink_to_fit() method call.
 ///
 /// The \c shrink_to_fit() method is more readable and more effective than
 /// the copy and swap trick to reduce the capacity of a shrinkable container.
 /// Note that, the \c shrink_to_fit() method is only available in C++11 and up.
 class ShrinkToFitCheck : public ClangTidyCheck {
 public:
   ShrinkToFitCheck(StringRef Name, ClangTidyContext *Context)
       : ClangTidyCheck(Name, Context) {}
   void registerMatchers(ast_matchers::MatchFinder *Finder) override;
   void check(const ast_matchers::MatchFinder::MatchResult &Result) override;
 };
 
+} // namespace readability
 } // namespace tidy
 } // namespace clang
 
 #endif // LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_READABILITY_SHRINK_TO_FIT_H

clang-tidy/readability/ShrinkToFitCheck.cpp

 AST_MATCHER(NamedDecl, stlShrinkableContainer) {
   return isShrinkableContainer(Node.getQualifiedNameAsString());
 }
 } // namespace ast_matchesr
 } // namespace clang
 
 namespace clang {
 namespace tidy {
+namespace readability {
 
 void ShrinkToFitCheck::registerMatchers(MatchFinder *Finder) {
   // Swap as a function need not to be considered, because rvalue can not
   // be bound to a non-const reference.
   const auto ShrinkableAsMember =
       memberExpr(member(valueDecl().bind("ContainerDecl")));
   const auto ShrinkableAsDecl =
       declRefExpr(hasDeclaration(valueDecl().bind("ContainerDecl")));
void ShrinkToFitCheck::check(const MatchFinder::MatchResult &Result) {
   }
 
   diag(MemberCall->getLocStart(), "the shrink_to_fit method should be used "
                                   "to reduce the capacity of a shrinkable "
                                   "container")
       << Hint;
 }
 
+} // namespace readability
 } // namespace tidy
 } // namespace clang