Page MenuHomePhabricator

Make print_cwd buildable on Windows
ClosedPublic

Authored by amccarth on Feb 27 2015, 2:28 PM.

Details

Summary

Original code relied on POSIX feature. This change doesn't completely enable process_launch tests on Windows, but it's another step in the chain.

Diff Detail

Repository
rL LLVM

Event Timeline

amccarth updated this revision to Diff 20903.Feb 27 2015, 2:28 PM
amccarth retitled this revision from to Make print_cwd buildable on Windows.
amccarth updated this object.
amccarth edited the test plan for this revision. (Show Details)
amccarth added a reviewer: zturner.
amccarth added a subscriber: Unknown Object (MLST).
zturner accepted this revision.Feb 27 2015, 2:42 PM
zturner edited edge metadata.
zturner added inline comments.
test/functionalities/process_launch/print_cwd.cpp
3 ↗(On Diff #20903)

I think this should be _MSC_VER. mingw toolchains will still have <unistd.h> and getcwd. We compile all our tests with clang, which does define _MSC_VER when in MSABI compat mode. lgtm otherwise, I'll commit later.

This revision is now accepted and ready to land.Feb 27 2015, 2:42 PM
amccarth updated this revision to Diff 20909.Feb 27 2015, 3:50 PM
amccarth edited edge metadata.

Makes sense. Changed to _MSC_VER. Thanks.

No worries, I would have changed it for you before submitting anyway :)
Thanks!

This revision was automatically updated to reflect the committed changes.