Page MenuHomePhabricator

[MemorySSA] Make MemoryLocation unknown when phi translation cannot be performed.
ClosedPublic

Authored by asbirlea on May 4 2020, 6:54 PM.

Details

Summary

When phi translation cannot be performed, be conservative and make the MemoryLocation unknown.

Diff Detail

Event Timeline

asbirlea created this revision.May 4 2020, 6:54 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 4 2020, 6:54 PM
Herald added a subscriber: Prazek. · View Herald Transcript
george.burgess.iv accepted this revision.May 5 2020, 9:12 AM

lgtm with one nit. thanks!

llvm/include/llvm/Analysis/MemorySSA.h
1232

AIUI, generally we try to treat MemoryLocations and LocationSizes as immutable. so we can keep with that, do you think Location = Location.getWithNewSize(LocationSize::unknown()); (and reverting the changes to MemoryLocation.h) is an acceptable alternative?

This revision is now accepted and ready to land.May 5 2020, 9:12 AM
asbirlea updated this revision to Diff 262191.May 5 2020, 12:41 PM

Address comment.
Thank you for the review!

asbirlea marked an inline comment as done.May 5 2020, 12:41 PM
This revision was automatically updated to reflect the committed changes.