There was no guarantee that the three threads haven't already exited by the
time the watchpoint is set.
Details
Diff Detail
Event Timeline
Please see my comments.
test/functionalities/watchpoint/hello_watchlocation/main.cpp | ||
---|---|---|
20–22 | Please follow the existing naming convention here - g_barrier ? | |
89 | My understanding the watchpoint is set for g_char_ptr variable but I don't see any command to set watchpoint - is watchpoint here set implicitly by lldb? | |
89 | Very minor unrelated thing - do we need to free this memory? |
Looks good.
test/functionalities/watchpoint/hello_watchlocation/main.cpp | ||
---|---|---|
21 | Please rename to g_barrier before submitting. |
Please rename to g_barrier before submitting.