This is an archive of the discontinued LLVM Phabricator instance.

Add -frtti and -fexceptions to tests that assume these are on.
ClosedPublic

Authored by filcab on Feb 25 2015, 4:43 PM.

Details

Summary

We now have targets that don't enable rtti/exceptions by default, and the
ASTMatchers tests are assuming that these features are on (e.g: They use
dynamic_cast or try).

Diff Detail

Repository
rL LLVM

Event Timeline

filcab updated this revision to Diff 20719.Feb 25 2015, 4:43 PM
filcab retitled this revision from to Add -frtti and -fexceptions to tests that assume these are on..
filcab updated this object.
filcab edited the test plan for this revision. (Show Details)
filcab added reviewers: klimek, thakis, djasper.
filcab added a subscriber: Unknown Object (MLST).
thakis accepted this revision.Mar 2 2015, 10:40 AM
thakis edited edge metadata.

I'm not familiar with this code, but the change makes "obviously sense". I think you can go ahead and land this.

This revision is now accepted and ready to land.Mar 2 2015, 10:40 AM
This revision was automatically updated to reflect the committed changes.