Remove use_pthread option from getBuildFlags in the test environment

[tberghammer]

Summary

Remove use_pthread option from getBuildFlags in the test environment

Removing the option to request the usage of pthread based on an argument of the getBuildFlags method in lldbtest.py because it can be specified by a variable in the makefile for the given test case. Using the variable in the makefile works in all supported platform based on some platform specific code in test/make/Makefile.rules while the getBuildFlags method haven't had any platform specific part what cause build failure on android.

lldb/trunk/test/functionalities/thread/create_after_attach/Makefile

 LEVEL = ../../../make
 
+ENABLE_THREADS := YES
 C_SOURCES := main.c
 include $(LEVEL)/Makefile.rules

lldb/trunk/test/functionalities/thread/exit_during_step/Makefile

 LEVEL = ../../../make
 
+ENABLE_THREADS := YES
 CXX_SOURCES := main.cpp
 include $(LEVEL)/Makefile.rules

lldb/trunk/test/functionalities/thread/jump/Makefile

 LEVEL = ../../../make
 
+ENABLE_THREADS := YES
 CXX_SOURCES := main.cpp other.cpp
 include $(LEVEL)/Makefile.rules

lldb/trunk/test/functionalities/thread/thread_exit/Makefile

 LEVEL = ../../../make
 
+ENABLE_THREADS := YES
 CXX_SOURCES := main.cpp
 include $(LEVEL)/Makefile.rules

lldb/trunk/test/lldbtest.py

def findBuiltClang(self):
         lldb_root_path = os.path.join(os.path.dirname(__file__), "..")
         for p in paths_to_try:
             path = os.path.join(lldb_root_path, p)
             if os.path.exists(path):
                 return path
         
         return os.environ["CC"]
 
-    def getBuildFlags(self, use_cpp11=True, use_libcxx=False, use_libstdcxx=False, use_pthreads=True):
+    def getBuildFlags(self, use_cpp11=True, use_libcxx=False, use_libstdcxx=False):
         """ Returns a dictionary (which can be provided to build* functions above) which
             contains OS-specific build flags.
         """
         cflags = ""
+        ldflags = ""
 
         # On Mac OS X, unless specifically requested to use libstdc++, use libc++
         if not use_libstdcxx and sys.platform.startswith('darwin'):
             use_libcxx = True
 
         if use_libcxx and self.libcxxPath:
             cflags += "-stdlib=libc++ "
             if self.libcxxPath:
                 libcxxInclude = os.path.join(self.libcxxPath, "include")
                 libcxxLib = os.path.join(self.libcxxPath, "lib")
                 if os.path.isdir(libcxxInclude) and os.path.isdir(libcxxLib):
                     cflags += "-nostdinc++ -I%s -L%s -Wl,-rpath,%s " % (libcxxInclude, libcxxLib, libcxxLib)
 
         if use_cpp11:
             cflags += "-std="
             if "gcc" in self.getCompiler() and "4.6" in self.getCompilerVersion():
                 cflags += "c++0x"
             else:
                 cflags += "c++11"
         if sys.platform.startswith("darwin") or sys.platform.startswith("freebsd"):
             cflags += " -stdlib=libc++"
         elif "clang" in self.getCompiler():
             cflags += " -stdlib=libstdc++"
 
-        if use_pthreads:
-            ldflags = "-lpthread"
-
         return {'CFLAGS_EXTRAS' : cflags,
                 'LD_EXTRAS' : ldflags,
                }
 
     def cleanup(self, dictionary=None):
         """Platform specific way to do cleanup after build."""
         if lldb.skip_build_and_cleanup:
             return