Page MenuHomePhabricator

Refactor lldb-mi tests
ClosedPublic

Authored by ki.stfu on Feb 19 2015, 9:35 AM.

Details

Summary

This patch includes following changes:

  • split lldb-mi tests into separate folders. It will make our life simpler because we can modify a test program of certain test and don't worry about other tests
  • a bit refactoring
  • fix comments
  • improve some tests

Diff Detail

Event Timeline

ki.stfu updated this revision to Diff 20307.Feb 19 2015, 9:35 AM
ki.stfu retitled this revision from to Refactor lldb-mi tests.
ki.stfu updated this object.
ki.stfu edited the test plan for this revision. (Show Details)
ki.stfu updated this revision to Diff 20330.Feb 19 2015, 12:21 PM

Refactor MiDataTestCase

ki.stfu updated this revision to Diff 20331.Feb 19 2015, 12:35 PM

Rename "evaluate" folder to "variable"

ki.stfu updated this revision to Diff 20333.Feb 19 2015, 12:54 PM

Update MiExitTestCase/MiSyntaxTestCase/MiLaunchTestCase; MiLaunchTestCase was renamed to MiFileTestCase

ki.stfu updated this revision to Diff 20335.Feb 19 2015, 1:20 PM

Refactor MiStackTestCase

ki.stfu updated this revision to Diff 20336.Feb 19 2015, 1:40 PM

Clean up test/tools/lldb-mi folder

TODO: I'll do the refactoring of these tests later:

  • MiExecTestCase
  • MiInterpreterExecTestCase
  • MiInterruptTestCase
  • MiNotificationTestCase
ki.stfu set the repository for this revision to rL LLVM.
ki.stfu added subscribers: abidh, emaste, Unknown Object (MLST), clayborg.
clayborg accepted this revision.Feb 19 2015, 3:30 PM
clayborg edited edge metadata.
This revision is now accepted and ready to land.Feb 19 2015, 3:30 PM
ki.stfu updated this revision to Diff 20397.Feb 20 2015, 6:56 AM
ki.stfu edited edge metadata.

Refactor MiExecTestCase; minor changes

abidh requested changes to this revision.Feb 20 2015, 7:33 AM
abidh edited edge metadata.

Please dont commit it for now. With this revision applied, I see a lot of error in Linux. Let me have a look first.

This revision now requires changes to proceed.Feb 20 2015, 7:33 AM

Ok, but I'm still working on it.

abidh accepted this revision.Feb 20 2015, 7:55 AM
abidh edited edge metadata.

Please make the following 2 changes and commit.
Enable all tests on Linux.
Fix the main.c as suggested in inline comments.

If there are some failures then I will fix/skip the tests as necessary.

test/tools/lldb-mi/symbol/main.cpp
15

This variable is undeclared. Causes build error.

This revision is now accepted and ready to land.Feb 20 2015, 7:55 AM
ki.stfu updated this revision to Diff 20407.Feb 20 2015, 8:20 AM
ki.stfu edited edge metadata.

Refactoring of all remaining tests. Remove all unnecessary files. Fix MiSymbolTestCase

ki.stfu updated this revision to Diff 20408.Feb 20 2015, 8:24 AM

Enable all tests on Linux

ki.stfu updated this revision to Diff 20409.Feb 20 2015, 8:31 AM

Add tests for -var-list-children

All tests pass on OS X. I'll commit it right now.

ki.stfu closed this revision.Feb 20 2015, 8:36 AM