This is an archive of the discontinued LLVM Phabricator instance.

Fix TestAttachDenied.py remote execution on Linux.
ClosedPublic

Authored by ovyalov on Feb 15 2015, 6:08 PM.

Details

Reviewers
vharron
Summary

TestAttachDenied should create the pipe on a target machine in case of remote execution - use SBPlatform::Run to create/read/remove a pipe either on local or remote machine.

Diff Detail

Event Timeline

ovyalov updated this revision to Diff 19996.Feb 15 2015, 6:08 PM
ovyalov retitled this revision from to Fix TestAttachDenied.py remote execution on Linux..
ovyalov updated this object.
ovyalov edited the test plan for this revision. (Show Details)
ovyalov added a reviewer: vharron.
ovyalov added a subscriber: Unknown Object (MLST).

Please let me know if you have any suggestions here - otherwise will be submitting it soon.

vharron accepted this revision.Feb 19 2015, 10:18 AM
vharron edited edge metadata.
vharron added inline comments.
test/functionalities/process_attach/attach_denied/TestAttachDenied.py
31

We want to be able to run this test from Windows against remote targets that support cat/mkfifo/rm. We need a new test decorator skipIfWindowsTarget (meaning Windows host is okay). Doesn't need to be in this CL.

This revision is now accepted and ready to land.Feb 19 2015, 10:18 AM
ovyalov added inline comments.Feb 19 2015, 2:05 PM
test/functionalities/process_attach/attach_denied/TestAttachDenied.py
31

OK, makes sense - let me get to this once I'll setup Windows station.