This is an archive of the discontinued LLVM Phabricator instance.

Fix mingw build.
ClosedPublic

Authored by abidh on Feb 10 2015, 8:17 AM.

Details

Reviewers
zturner
Summary

Following changes are done.

  1. Add missing headers.
  2. Replace _snprintf with snprintf. It is already changed to _snprintf for MSVC.
  3. Add a file in the build for autoconf.
  4. Exclude DynamicLoaderWindows::Terminate from mingw build as DynamicLoaderWindows::Initialize is done.

Built on Linux and Windows.

Diff Detail

Event Timeline

abidh updated this revision to Diff 19684.Feb 10 2015, 8:17 AM
abidh retitled this revision from to Fix mingw build..
abidh updated this object.
abidh edited the test plan for this revision. (Show Details)
abidh added a reviewer: zturner.
abidh added a subscriber: Unknown Object (MLST).
zturner edited edge metadata.Feb 10 2015, 8:24 AM

Can you change DynamicLoaderWindows calls to be #if defined(_MSC_VER)?
Otherwise lgtm

abidh updated this revision to Diff 19686.Feb 10 2015, 8:48 AM
abidh edited edge metadata.
  • Replaced some check from (win32 && !mingw) to _MSC_VER.
abidh added a comment.Feb 10 2015, 8:50 AM

I have done the change requested. Please accept if it look good.

zturner accepted this revision.Feb 10 2015, 9:37 AM
zturner edited edge metadata.
This revision is now accepted and ready to land.Feb 10 2015, 9:37 AM
abidh closed this revision.Feb 11 2015, 2:16 AM

Committed in 228822.