This is an archive of the discontinued LLVM Phabricator instance.

Differential D7534

Fix dependency-generation-crash test to actually execute clang and to clean up after itself
ClosedPublic

Authored by gbedwell on Feb 10 2015, 6:27 AM.

Details

Reviewers
bogner
Commits
rG421f669215f8: Fix dependency generation crash test to run clang and clean up after itself.
rC228919: Fix dependency generation crash test to run clang and clean up after itself.
rL228919: Fix dependency generation crash test to run clang and clean up after itself.
Summary

I've been having an issue on my Windows box where often my build directory would not be able to be deleted from a script due to a permission denied error from a temp file created during one of the Clang tests. Looking at the test, it appears to be badly formed, creating a temp file and then removing all permissions via chmod without actually involving clang at all. I've attempted to fix the test to carry out what I think is its original intent and made sure it cleans up after itself on success now so fixes my original issue of not being able to delete the build folder.

Thanks,

Greg Bedwell
SN Systems - Sony Computer Entertainment Inc.

Diff Detail

Repository
rL LLVM

Event Timeline

gbedwell updated this revision to Diff 19672.Feb 10 2015, 6:27 AM
gbedwell retitled this revision from to Fix dependency-generation-crash test to actually execute clang and to clean up after itself.
gbedwell updated this object.
gbedwell edited the test plan for this revision. (Show Details)
gbedwell added a reviewer: bogner.
gbedwell added a subscriber: Unknown Object (MLST).
Closed by commit rL228919: Fix dependency generation crash test to run clang and clean up after itself. (authored by gbedwell). · Explain WhyFeb 12 2015, 4:43 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
cfe/
trunk/
test/
Frontend/
6 lines

Diff 19818

cfe/trunk/test/Frontend/dependency-generation-crash.c

// RUN: touch %t // RUN: touch %t
// RUN: chmod 0 %t // RUN: chmod 0 %t
// %clang -E -dependency-file bla -MT %t -MP -o %t -x c /dev/null // RUN: not %clang_cc1 -E -dependency-file bla -MT %t -MP -o %t -x c /dev/null 2>&1 | FileCheck %s
// RUN: rm -f %t
// CHECK: error: unable to open output file
// rdar://9286457 // rdar://9286457