This is an archive of the discontinued LLVM Phabricator instance.

Add LLDB x86_64 Ubuntu 14.04 builder
ClosedPublic

Authored by chying on Feb 9 2015, 4:26 PM.

Details

Summary

Added new lldb builder, for x86_64 Ubuntu

Diff Detail

Event Timeline

chying updated this revision to Diff 19628.Feb 9 2015, 4:26 PM
chying retitled this revision from to Add LLDB x86_64 Ubuntu 14.04 builder.
chying updated this object.
chying edited the test plan for this revision. (Show Details)
chying added reviewers: sivachandra, ovyalov, chaoren.
chying added a subscriber: Unknown Object (MLST).
sivachandra added inline comments.Feb 9 2015, 7:01 PM
buildbot/osuosl/master/config/builders.py
684

I could have missed, but don't remember seeing a patch which added getLLDBUbuntuCMakeBuildFactory. Is there one on phabricator?

buildbot/osuosl/master/config/slaves.py
189

Is this accurate?

chying added inline comments.Feb 10 2015, 10:05 AM
buildbot/osuosl/master/config/builders.py
684

Thank you Siva.
Yes, there's another patch adding getLLDBUbuntuCMakeBuildFactory.
Somehow it did not generate email to reviewers.
Here is the link,
http://reviews.llvm.org/D7521

buildbot/osuosl/master/config/slaves.py
189

The information was from running $lshw on builder.

sivachandra added inline comments.Feb 10 2015, 11:48 AM
buildbot/osuosl/master/config/builders.py
684

Thanks.
Should the builder name reflect that this uses cmake? For example, lldb-x86_64-ubuntu-14.04-cmake? [That it uses ninja is probably not that very important that it should be captured in the builder name.]

buildbot/osuosl/master/config/slaves.py
189

Is this guaranteed? That is, does GCE guarantee that this will not change? Why is it important to have a comment describing the hardware?

chying added inline comments.Feb 10 2015, 7:11 PM
buildbot/osuosl/master/config/builders.py
684

That's a good idea. I will create another patch to update the name so it's more descriptive.

buildbot/osuosl/master/config/slaves.py
189

Based on the following statement from GCE docs, the resources should not change as long as the machine type has been selected. "The number of virtual CPUs, amount of memory supported by the VM is dependent on the machine type selected"
The hardware information was added by following convention of existing slaves... I guess it would sort of indicate the performance of builder?

sivachandra accepted this revision.Feb 10 2015, 8:42 PM
sivachandra edited edge metadata.

Good to go after the builder name change.

I think this patch should wait for D7521? I am still reviewing it.

This revision is now accepted and ready to land.Feb 10 2015, 8:42 PM
sivachandra added inline comments.Feb 10 2015, 10:27 PM
buildbot/osuosl/master/config/slaves.py
189

I am more concerned about "Intel(R) Xeon(R) CPU @ 2.60GHz". But it is not an issue to continue beating around it. It is up to you to keep it or take it off.

chying closed this revision.Feb 24 2015, 6:00 PM

Revision has been committed to origin