Page MenuHomePhabricator

Fix -stack-list-locals and -stack-list-arguments (MI)
ClosedPublic

Authored by ki.stfu on Feb 6 2015, 3:10 AM.

Details

Summary

These changes include:

  • Add eVariableInfoFormat argument for MIResponseFormVariableInfo{,2,3} and GetVariableInfo{,2} functions
  • Fix -stack-list-locals and -stack-list-arguments: they ingored print-values
  • Enable MiStackTestCase tests for -stack-list-xxx commands

All test pass on OS X.

Diff Detail

Repository
rL LLVM

Event Timeline

ki.stfu updated this revision to Diff 19470.Feb 6 2015, 3:10 AM
ki.stfu retitled this revision from to Fix -stack-list-locals and -stack-list-arguments (MI).
ki.stfu updated this object.
ki.stfu edited the test plan for this revision. (Show Details)
ki.stfu added reviewers: abidh, clayborg.
ki.stfu added subscribers: abidh, clayborg, Unknown Object (MLST).
ki.stfu updated this object.Feb 6 2015, 3:14 AM
ki.stfu updated this object.Feb 6 2015, 3:18 AM
ki.stfu set the repository for this revision to rL LLVM.
abidh edited edge metadata.Feb 6 2015, 3:55 AM

Looks good to me. Although you can also handle --no-values, --all-values and --simple-values. I committed one patch yesterday that was using those for -var-list-children. I think eclipse uses those options instead of using --print-value.
Please note that I am working on a patch that touches the same area. It will be good if you can apply it quickly so that I can rebase my work to the latest.

abidh accepted this revision.Feb 6 2015, 3:56 AM
abidh edited edge metadata.
This revision is now accepted and ready to land.Feb 6 2015, 3:56 AM
In D7462#119705, @abidh wrote:

Looks good to me. Although you can also handle --no-values, --all-values and --simple-values. I committed one patch yesterday that was using those for -var-list-children. I think eclipse uses those options instead of using --print-value.
Please note that I am working on a patch that touches the same area. It will be good if you can apply it quickly so that I can rebase my work to the latest.

I'll try to do it now.

ki.stfu updated this revision to Diff 19475.Feb 6 2015, 4:25 AM
ki.stfu edited edge metadata.

Update patch:

  • Add --no-values/--all-values/--simple-values options
  • Improve MiStackTestCase tests
In D7462#119705, @abidh wrote:

Looks good to me. Although you can also handle --no-values, --all-values and --simple-values. I committed one patch yesterday that was using those for -var-list-children. I think eclipse uses those options instead of using --print-value.
Please note that I am working on a patch that touches the same area. It will be good if you can apply it quickly so that I can rebase my work to the latest.

I'll try to do it now.

I have done it. I gonna commit this patch today if there are no objections

ki.stfu closed this revision.Feb 6 2015, 10:10 AM
This revision was automatically updated to reflect the committed changes.