This is an archive of the discontinued LLVM Phabricator instance.

Differential D7446

[libcxxabi] Install header files
ClosedPublic

Authored by garious on Feb 5 2015, 11:58 AM.

Details

Reviewers
danalbert
jroelofs
Summary

Without this patch, libcxx needs to point to libcxxabi's source directory for its headers and its install directory for its compiled library. We can simplify libcxx's build configuration if libcxxabi adds its public headers to the install directory.

This patch adds a CMake rule to install the headers to the same location they appear on OS X.

Diff Detail

Repository
rL LLVM

Event Timeline

garious updated this revision to Diff 19423.Feb 5 2015, 11:58 AM
garious retitled this revision from to [libcxxabi] Install header files.
garious updated this object.
garious edited the test plan for this revision. (Show Details)
garious added a reviewer: danalbert.
garious set the repository for this revision to rL LLVM.
garious added a subscriber: Unknown Object (MLST).
garious added a reviewer: jroelofs.Feb 5 2015, 2:39 PM
danalbert accepted this revision.Feb 5 2015, 2:43 PM
danalbert edited edge metadata.

LGTM.

This revision is now accepted and ready to land.Feb 5 2015, 2:43 PM
garious closed this revision.Feb 5 2015, 2:49 PM

Thanks! Committed in r228351

Revision Contents

PathSize
7 lines

Diff 19423

CMakeLists.txt

Context not available.
else() else()
add_subdirectory(test) add_subdirectory(test)
endif() endif()
install(DIRECTORY include/
DESTINATION include
FILES_MATCHING
PATTERN "*.h"
PATTERN ".svn" EXCLUDE
)
Context not available.