This is an archive of the discontinued LLVM Phabricator instance.

Fix an incorrect identifier
ClosedPublic

Authored by sylvestre.ledru on Feb 5 2015, 6:58 AM.

Details

Summary

EIEIO is not a correct declaration and breaks the build under Debian HURD.
Instead, E_IEIO is used.


http://www.gnu.org/software/libc/manual/html_node/Reserved-Names.html
Some additional classes of identifier names are reserved for future
extensions to the C language or the POSIX.1 environment. While using
these names for your own purposes right now might not cause a problem,
they do raise the possibility of conflict with future versions of the C
or POSIX standards, so you should avoid these names.
...
Names beginning with a capital ‘E’ followed a digit or uppercase letter
may be used for additional error code names. See Error Reporting.

Reported here:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=776965
And patch wrote by Svante Signell
With this patch, LLVM, Clang & LLDB build under Debian HURD:
https://buildd.debian.org/status/fetch.php?pkg=llvm-toolchain-3.6&arch=hurd-i386&ver=1%3A3.6~%2Brc2-2&stamp=1423040039

Diff Detail

Repository
rL LLVM

Event Timeline

sylvestre.ledru retitled this revision from to Fix an incorrect identifier.
sylvestre.ledru updated this object.
sylvestre.ledru edited the test plan for this revision. (Show Details)
sylvestre.ledru added a reviewer: hfinkel.
sylvestre.ledru set the repository for this revision to rL LLVM.
sylvestre.ledru added a subscriber: Unknown Object (MLST).
hfinkel accepted this revision.Feb 5 2015, 9:20 AM
hfinkel edited edge metadata.

LGTM, but please make it EnforceIEIO -- I'm against adding arbitrary underscores, but making it more descriptive is okay ;) -- Also, add a comment explaining the naming constraint.

This revision is now accepted and ready to land.Feb 5 2015, 9:20 AM