Page MenuHomePhabricator

Add additional DWARF 5 language constants.
ClosedPublic

Authored by brucem on Feb 5 2015, 2:38 AM.

Details

Summary

This also hooks up the new C++14 language constant to be treated
the same as the other C++ language constants.

Diff Detail

Repository
rL LLVM

Event Timeline

brucem updated this revision to Diff 19386.Feb 5 2015, 2:38 AM
brucem retitled this revision from to Add additional DWARF 5 language constants..
brucem updated this object.
brucem edited the test plan for this revision. (Show Details)
brucem added a reviewer: clayborg.
brucem added a subscriber: Unknown Object (MLST).
brucem updated this revision to Diff 19387.Feb 5 2015, 2:46 AM

Fixing a typo.

brucem edited subscribers, added: Unknown Object (MLST); removed: Unknown Object (MLST).Feb 5 2015, 2:59 AM
clayborg accepted this revision.Feb 5 2015, 9:52 AM
clayborg edited edge metadata.

looks good

This revision is now accepted and ready to land.Feb 5 2015, 9:52 AM

Hey Greg,

I'd been mostly trying to avoid throwing all of the DWARF5 stuff in until
at least a preliminary version was released, but as long as everyone is OK
with the numbers possibly changing then I guess it's ok. I'd asked Bruce in
the clang side of the patch to hold off a bit.

Thoughts?

-eric

As you can see in this patch, the new language constants up to 0x0020 are already in LLDB. (I added them some months ago as I work on Dylan (among other things) and have started to do Dylan support in LLDB.)

I would say to check them in and modify them when/if we need to. People need to start testing their DWARF5 functionality and LLD is a good way to start testing it. Maybe we should add a comment next to each language define:

// NOTE: DWARF5 constant, subject to change upon completion of the DWARF5 specification

Thoughts?

Sure. SGTM. I'll update the llvm side of things.

-eric

brucem updated this revision to Diff 19459.Feb 5 2015, 10:45 PM
brucem edited edge metadata.

Add comment per request.

This revision was automatically updated to reflect the committed changes.