This is an archive of the discontinued LLVM Phabricator instance.

Force an unknown target for the default case to make it work.
ClosedPublic

Authored by filcab on Feb 4 2015, 5:42 PM.

Download Raw Diff

Details

Reviewers

chandlerc
echristo

Commits

rG566e584bd4a1: Force an unknown target for the default case to make it work.
rC228337: Force an unknown target for the default case to make it work.
rL228337: Force an unknown target for the default case to make it work.

Summary

This test was failing if LLVM_DEFAULT_TARGET_TRIPLE=x86_64-scei-ps4 due to
its behavior for exceptions.
Force an --unknown triple for the default case.

Diff Detail

Repository: rL LLVM

Event Timeline

filcab updated this revision to Diff 19366.Feb 4 2015, 5:42 PM

filcab retitled this revision from to Force an unknown target for the default case to make it work..

filcab updated this object.

filcab edited the test plan for this revision. (Show Details)

filcab added a reviewer: echristo.

filcab added a subscriber: Unknown Object (MLST).

Looks good with a less overly specific comment (see below)

test/Driver/clang-exception-flags.cpp
1–3 ↗	(On Diff #19366)	I would just say that the default behavior of exception handling in target specific.

This revision is now accepted and ready to land.Feb 5 2015, 10:08 AM

Closed by commit rL228337: Force an unknown target for the default case to make it work. (authored by filcab). · Explain WhyFeb 5 2015, 11:50 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents

Path

Size

cfe/

trunk/

test/

Driver/

clang-exception-flags.cpp

4 lines

Diff 19422

cfe/trunk/test/Driver/clang-exception-flags.cpp

	// RUN: %clang -### %s 2>&1 \| FileCheck %s -check-prefix=DEFAULT			// We force the target to unknown because clang's default behavior for
				// exception handling is target dependent.
				// RUN: %clang -### -target unknown %s 2>&1 \| FileCheck %s -check-prefix=DEFAULT
	// DEFAULT: "-cc1" {{.*}} "-fcxx-exceptions" "-fexceptions"			// DEFAULT: "-cc1" {{.*}} "-fcxx-exceptions" "-fexceptions"
	//			//
	// RUN: %clang -### -fexceptions %s 2>&1 \| FileCheck %s -check-prefix=ON1			// RUN: %clang -### -fexceptions %s 2>&1 \| FileCheck %s -check-prefix=ON1
	// ON1: "-cc1" {{.*}} "-fcxx-exceptions" "-fexceptions"			// ON1: "-cc1" {{.*}} "-fcxx-exceptions" "-fexceptions"
	//			//
	// RUN: %clang -### -fno-exceptions -fcxx-exceptions %s 2>&1 \| FileCheck %s -check-prefix=ON2			// RUN: %clang -### -fno-exceptions -fcxx-exceptions %s 2>&1 \| FileCheck %s -check-prefix=ON2
	// ON2: "-cc1" {{.*}} "-fcxx-exceptions" "-fexceptions"			// ON2: "-cc1" {{.*}} "-fcxx-exceptions" "-fexceptions"
	//			//
	Show All 14 Lines