This is an archive of the discontinued LLVM Phabricator instance.

[libcxx] Add <experimental/chrono>
ClosedPublic

Authored by EricWF on Feb 2 2015, 11:58 AM.

Diff Detail

Event Timeline

EricWF updated this revision to Diff 19175.Feb 2 2015, 11:58 AM
EricWF retitled this revision from to [libcxx] Add <experimental/chrono>.
EricWF updated this object.
EricWF edited the test plan for this revision. (Show Details)
EricWF added a subscriber: Unknown Object (MLST).
mclow.lists edited edge metadata.Feb 2 2015, 12:10 PM

Other than the namespace issue, this looks good.

include/experimental/chrono
43

I think this needs to go into std::__1::chrono

So we could write

_LIBCPP_BEGIN_NAMESPACE_STD
namespace chrono {
    namespace experimental { inline namespace fundamentals_v1 {

Maybe there needs to be a macro for this; or just for the "namespace experimental { inline namespace fundamentals_v1 {`" part.

EricWF updated this revision to Diff 19177.Feb 2 2015, 12:19 PM
EricWF edited edge metadata.

Add _LIBCPP_BEGIN_NAMESPACE_CHRONO_LFTS and _LIBCPP_END_NAMESPACE_CHRONO_LFTS.

EricWF updated this revision to Diff 19178.Feb 2 2015, 12:23 PM

Do a better job of reusing config namespace macros.

mclow.lists accepted this revision.Feb 2 2015, 12:53 PM
mclow.lists edited edge metadata.

LGTM

This revision is now accepted and ready to land.Feb 2 2015, 12:53 PM
EricWF closed this revision.Feb 2 2015, 1:07 PM