This is an archive of the discontinued LLVM Phabricator instance.

AArch64: Add INITIALIZE_PASS_* macros to AArch64A57FPLoadBalancing.
ClosedPublic

Authored by gberry on Jan 29 2015, 2:13 PM.

Details

Summary

These are needed so this pass will produce output when
e.g. -print-after-all is used.

Diff Detail

Event Timeline

gberry updated this revision to Diff 18985.Jan 29 2015, 2:13 PM
gberry retitled this revision from to AArch64: Add INITIALIZE_PASS_* macros to AArch64A57FPLoadBalancing. .
gberry updated this object.
gberry edited the test plan for this revision. (Show Details)
gberry added reviewers: jmolloy, mcrosier, apazos.
gberry set the repository for this revision to rL LLVM.
gberry added a subscriber: Unknown Object (MLST).
mcrosier added inline comments.Jan 29 2015, 2:47 PM
lib/Target/AArch64/AArch64A57FPLoadBalancing.cpp
157

Since we don't need to initialize any pass dependencies (e.g., AliasAnalysis), I don't think we need both the BEGIN and END macros; a singleINITIALIZE_PASS would suffice. However, I don't think it really matters.

mcrosier accepted this revision.Jan 29 2015, 2:55 PM
mcrosier edited edge metadata.
This revision is now accepted and ready to land.Jan 29 2015, 2:55 PM
mcrosier closed this revision.Jan 29 2015, 2:59 PM

Committed r227506.