This is an archive of the discontinued LLVM Phabricator instance.

[compiler-rt] Turn abort_on_error=1 by default on OS X (part 2/2)
AbandonedPublic

Authored by kubamracek on Jan 27 2015, 10:58 AM.

Details

Reviewers
None
Summary

See part 1 at http://reviews.llvm.org/D7203.

This is part 2 of the patch that contains modifications of existing tests.

Individual test cases that override ASAN_OPTIONS are changed to respect the default ASAN_OPTIONS environment variable set by lit. The diff is basically the result of this command:

find . -type f | xargs sed -E -i "" 's/ASAN_OPTIONS=([^$])/ASAN_OPTIONS=$ASAN_OPTIONS:\1/g'

with a a manual modification in malloc_delete_mismatch.cc (because ASAN_OPTIONS is used in a help message).

Diff Detail

Event Timeline

kubamracek retitled this revision from to [compiler-rt] Turn abort_on_error=1 by default on OS X (part 2/2).
kubamracek updated this object.
kubamracek edited the test plan for this revision. (Show Details)
kubamracek added subscribers: Unknown Object (MLST), glider, samsonov and 2 others.
kcc added a comment.Jan 27 2015, 12:08 PM

I am not sure this is a great idea. This makes the tests non-hermetic (or at least, less hermetic)

In D7204#114162, @kcc wrote:

I am not sure this is a great idea. This makes the tests non-hermetic (or at least, less hermetic)

I tend to agree with that. We shouldn't depend on ASAN_OPTIONS specified in the system environment when we're running the tests (and ASAN_OPTIONS is explicitly propagated from system env by lit).

However, if you really want to override ASAN_OPTIONS to use "abort_on_error=true", this change might be OK, provided that you unconditionally overwrite ASAN_OPTIONS from config.environment with this value.

kubamracek abandoned this revision.Jul 21 2015, 5:21 AM