This is an archive of the discontinued LLVM Phabricator instance.

[mips] Enable arithmetic and binary operations for the i128 data type.
ClosedPublic

Authored by vkalintiris on Jan 23 2015, 5:53 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

vkalintiris retitled this revision from to [mips] Enable arithmetic and binary operations for the i128 data type..
vkalintiris updated this object.
vkalintiris edited the test plan for this revision. (Show Details)
vkalintiris added a reviewer: dsanders.
vkalintiris added a subscriber: Unknown Object (MLST).
dsanders accepted this revision.Jan 24 2015, 5:49 AM
dsanders edited edge metadata.

LGTM with the comment. As with the other patch, please try to annotate the redundant instructions with FIXME's but there's quite a few so I'm not going to require that.

I was reminded last night that I hadn't committed the add/sub portion I did a few weeks back. I committed it today as r227003. Feel free to revert it if the conflict is awkward since your patch makes the same change and fixes all the other operations too.

lib/Target/Mips/MipsSEISelDAGToDAG.cpp
251–256 ↗(On Diff #18671)

Please add a comment about this. I believe you are working around the fact that we currently use i32 for conditions on MIPS64 but we should probably be using i64.

This revision is now accepted and ready to land.Jan 24 2015, 5:49 AM
This revision was automatically updated to reflect the committed changes.