This is an archive of the discontinued LLVM Phabricator instance.

Differential D7142

[Clang Tidy] Small readability-container-size-empty cleanup
ClosedPublic

Authored by xazax.hun on Jan 23 2015, 5:40 AM.

Details

Reviewers
alexfh
Summary

Utilized the hasEitherOperand instead of explicit anyOf.

Diff Detail

Event Timeline

xazax.hun updated this revision to Diff 18666.Jan 23 2015, 5:40 AM
xazax.hun retitled this revision from to [Clang Tidy] Small readability-container-size-empty cleanup.
xazax.hun updated this object.
xazax.hun edited the test plan for this revision. (Show Details)
xazax.hun added a reviewer: alexfh.
xazax.hun added a subscriber: Unknown Object (MLST).
alexfh accepted this revision.Jan 23 2015, 6:41 AM
alexfh edited edge metadata.

Looks good!

I'll commit the patch.

This revision is now accepted and ready to land.Jan 23 2015, 6:41 AM
alexfh closed this revision.Jan 23 2015, 6:45 AM

Committed revision 226911.

Revision Contents

PathSize
clang-tidy/
readability/
3 lines

Diff 18666

clang-tidy/readability/ContainerSizeEmpty.cpp

Context not available.
anyOf(has(integerLiteral(equals(0))), anyOf(has(integerLiteral(equals(0))),
allOf(anyOf(hasOperatorName("<"), hasOperatorName(">="), allOf(anyOf(hasOperatorName("<"), hasOperatorName(">="),
hasOperatorName(">"), hasOperatorName("<=")), hasOperatorName(">"), hasOperatorName("<=")),
anyOf(hasRHS(integerLiteral(equals(1))), hasEitherOperand(integerLiteral(equals(1))))))
hasLHS(integerLiteral(equals(1)))))))
.bind("SizeBinaryOp")), .bind("SizeBinaryOp")),
hasParent(implicitCastExpr( hasParent(implicitCastExpr(
hasImplicitDestinationType(isBoolType()), hasImplicitDestinationType(isBoolType()),
Context not available.