This is an archive of the discontinued LLVM Phabricator instance.

[libcxx] Add support for std::reinterpret_pointer_cast
AbandonedPublic

Authored by ldionne on Nov 26 2019, 4:43 PM.

Details

Reviewers
mclow.lists
MU001999
Group Reviewers
Restricted Project
Summary

Add the implementation of std::reinterpret_pointer_cast.

Diff Detail

Event Timeline

MU001999 created this revision.Nov 26 2019, 4:43 PM
Herald added a project: Restricted Project. · View Herald Transcript

You have no tests.
If you had tests, you would probably have noticed that you typed _UP when you meant _Up

mclow.lists requested changes to this revision.Jan 20 2020, 8:12 PM
This revision now requires changes to proceed.Jan 20 2020, 8:12 PM
MU001999 updated this revision to Diff 239229.Jan 20 2020, 10:00 PM

Fix UP to Up

mclow.lists requested changes to this revision.Jan 23 2020, 7:14 AM

Still no tests. This will not be committed w/o tests.

This revision now requires changes to proceed.Jan 23 2020, 7:14 AM
MU001999 updated this revision to Diff 240089.Jan 23 2020, 8:37 PM

Add the test

It looks like this has been implemented in ce195fb22b542c20745e3ed46d1516e8b4e3a76f.

ldionne commandeered this revision.May 14 2020, 6:24 AM
ldionne added a reviewer: MU001999.
ldionne abandoned this revision.May 14 2020, 6:24 AM

@MU001999 I'm sorry we were not quicker to review this one, and look forward to doing better on your future contributions.