Page MenuHomePhabricator

Fix AbbreviationsTestCase, AliasTestCase and HelpCommandTestCase tests after r226068
ClosedPublic

Authored by ki.stfu on Jan 20 2015, 5:34 AM.

Details

Summary

This patch fixes the following cases:

  1. test_nonrunning_command_abbreviations (TestAbbreviations.AbbreviationsTestCase):
$ ./dotest.py -v --executable $BUILDDIR/bin/lldb -f AbbreviationsTestCase.test_nonrunning_command_abbreviations
['./dotest.py', '-v', '--executable', '/Users/IliaK/p/llvm/build_ninja/bin/lldb', '-f', 'AbbreviationsTestCase.test_nonrunning_command_abbreviations']
LLDB library dir: /Users/IliaK/p/llvm/build_ninja/bin
lldb-330.99.0
lldb.pre_flight: None
lldb.post_flight: None

Session logs for test failures/errors/unexpected successes will go into directory '2015-01-20-16_17_43'
Command invoked: ./dotest.py -v --executable /Users/IliaK/p/llvm/build_ninja/bin/lldb -f AbbreviationsTestCase.test_nonrunning_command_abbreviations
compilers=['clang']

Configuration: arch=x86_64 compiler=clang
----------------------------------------------------------------------
Collected 1 test

1: test_nonrunning_command_abbreviations (TestAbbreviations.AbbreviationsTestCase) ... FAILURE

======================================================================
FAIL: test_nonrunning_command_abbreviations (TestAbbreviations.AbbreviationsTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/IliaK/p/llvm/tools/lldb/test/functionalities/abbreviation/TestAbbreviations.py", line 37, in test_nonrunning_command_abbreviations
    startstr = "The following is a list of built-in, permanent debugger commands:")
  File "/Users/IliaK/p/llvm/tools/lldb/test/lldbtest.py", line 2011, in expect
    msg if msg else EXP_MSG(str, exe))
AssertionError: False is not True : 'h' returns expected result
Config=x86_64-clang
----------------------------------------------------------------------
Ran 1 test in 0.966s

FAILED (failures=1)
Session logs for test failures/errors/unexpected successes can be found in directory '2015-01-20-16_17_43'
  1. test_with_dsym (TestAliases.AliasTestCase):
======================================================================
FAIL: test_with_dsym (TestAliases.AliasTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/IliaK/p/llvm/tools/lldb/test/lldbtest.py", line 382, in wrapper
    return func(self, *args, **kwargs)
  File "/Users/IliaK/p/llvm/tools/lldb/test/functionalities/alias/TestAliases.py", line 19, in test_with_dsym
    self.alias_tests ()
  File "/Users/IliaK/p/llvm/tools/lldb/test/functionalities/alias/TestAliases.py", line 118, in alias_tests
    substrs = [ 'run', 'process launch -c /bin/sh' ])
  File "/Users/IliaK/p/llvm/tools/lldb/test/lldbtest.py", line 2011, in expect
    msg if msg else EXP_MSG(str, exe))
AssertionError: False is not True : 'process launch -c /bin/sh' returns expected result
Config=x86_64-clang
----------------------------------------------------------------------
Ran 1 test in 0.747s

FAILED (failures=1)
  1. test_with_dwarf (TestAliases.AliasTestCase):
======================================================================
FAIL: test_with_dwarf (TestAliases.AliasTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/IliaK/p/llvm/tools/lldb/test/lldbtest.py", line 399, in wrapper
    return func(self, *args, **kwargs)
  File "/Users/IliaK/p/llvm/tools/lldb/test/functionalities/alias/TestAliases.py", line 24, in test_with_dwarf
    self.alias_tests ()
  File "/Users/IliaK/p/llvm/tools/lldb/test/functionalities/alias/TestAliases.py", line 118, in alias_tests
    substrs = [ 'run', 'process launch -c /bin/sh' ])
  File "/Users/IliaK/p/llvm/tools/lldb/test/lldbtest.py", line 2011, in expect
    msg if msg else EXP_MSG(str, exe))
AssertionError: False is not True : 'process launch -c /bin/sh' returns expected result
Config=x86_64-clang
----------------------------------------------------------------------
Ran 1 test in 0.741s

FAILED (failures=1)
  1. test_help_on_help (TestHelp.HelpCommandTestCase)
  2. test_help_should_not_hang_emacsshell (TestHelp.HelpCommandTestCase)
  3. test_simplehelp (TestHelp.HelpCommandTestCase)

These bugs were introduced by r226068 - Three related changes to help.

Diff Detail

Repository
rL LLVM

Event Timeline

ki.stfu updated this revision to Diff 18425.Jan 20 2015, 5:34 AM
ki.stfu retitled this revision from to Fix test_nonrunning_command_abbreviations in AbbreviationsTestCase after r226068.
ki.stfu updated this object.
ki.stfu edited the test plan for this revision. (Show Details)
ki.stfu added a subscriber: Unknown Object (MLST).
emaste accepted this revision.Jan 20 2015, 6:35 AM
emaste added a reviewer: emaste.
emaste added a subscriber: emaste.
This comment was removed by emaste.
This revision is now accepted and ready to land.Jan 20 2015, 6:35 AM
ki.stfu updated this revision to Diff 18427.Jan 20 2015, 6:41 AM
ki.stfu retitled this revision from Fix test_nonrunning_command_abbreviations in AbbreviationsTestCase after r226068 to Fix AbbreviationsTestCase and AliasTestCase tests after r226068.
ki.stfu updated this object.
ki.stfu edited edge metadata.

Fix AliasTestCase tests.

This comment was removed by ki.stfu.
ki.stfu updated this revision to Diff 18428.Jan 20 2015, 7:00 AM
ki.stfu retitled this revision from Fix AbbreviationsTestCase and AliasTestCase tests after r226068 to Fix AbbreviationsTestCase, AliasTestCase and HelpCommandTestCase tests after r226068.
ki.stfu updated this object.

Fix HelpCommandTestCase tests.

BTW, I don't have the write access yet. Could somebody commit it?

This revision was automatically updated to reflect the committed changes.