This is an archive of the discontinued LLVM Phabricator instance.

Handle LLVM_USE_SANITIZER=Address;Undefined (and the other way around)
ClosedPublic

Authored by filcab on Jan 16 2015, 2:39 PM.

Details

Summary

Handle LLVM_USE_SANITIZER=Address;Undefined to enable ASan and UBSan
If UBSan is compatible with more of the other sanitizers, maybe we should
deal with this in a better way where we allow combining UBSan with any of
the other sanitizers.

Diff Detail

Event Timeline

filcab updated this revision to Diff 18324.Jan 16 2015, 2:39 PM
filcab retitled this revision from to Handle LLVM_USE_SANITIZER=Address;Undefined (and the other way around).
filcab updated this object.
filcab edited the test plan for this revision. (Show Details)
filcab added a reviewer: samsonov.
filcab added a subscriber: Unknown Object (MLST).
samsonov edited edge metadata.Feb 4 2015, 2:07 PM

LGTM after fixing a nit below. We don't plan to support running UBSan with any other sanitizer except for ASan in the short term.

cmake/modules/HandleLLVMOptions.cmake
401

You can use a single append() statement:

append("-fsanitize=address,undefined -fno-sanitize=...")
samsonov accepted this revision.Feb 4 2015, 2:07 PM
samsonov edited edge metadata.
This revision is now accepted and ready to land.Feb 4 2015, 2:07 PM
This revision was automatically updated to reflect the committed changes.