This is an archive of the discontinued LLVM Phabricator instance.

Remove repository pathname dependence in test
ClosedPublic

Authored by david2050 on Jan 15 2015, 11:07 AM.

Details

Reviewers
echristo
Summary

This test fails whenever the local repository has 'call' in its path name. Modified to avoid this

Diff Detail

Event Timeline

david2050 updated this revision to Diff 18238.Jan 15 2015, 11:07 AM
david2050 retitled this revision from to Remove repository pathname dependence in test.
david2050 updated this object.
david2050 edited the test plan for this revision. (Show Details)
david2050 added a reviewer: echristo.
david2050 set the repository for this revision to rL LLVM.
david2050 added subscribers: Unknown Object (MLST), freik.
echristo edited edge metadata.Jan 15 2015, 11:27 AM

Converting this to FileCheck would be preferred here.

Thanks!

-eric

To elaborate you could do a:

CHECK: ModuleID
CHECK-NOT: call

As far as I can tell the grep -v for llvm.isunordered isn't an issue anymore.

-eric

david2050 updated this revision to Diff 18268.Jan 15 2015, 3:05 PM
david2050 edited edge metadata.
david2050 removed rL LLVM as the repository for this revision.

Per review comments, modified to use FileCheck

echristo accepted this revision.Jan 15 2015, 3:06 PM
echristo edited edge metadata.

That also works. LGTM.

-eric

This revision is now accepted and ready to land.Jan 15 2015, 3:06 PM
echristo closed this revision.Jan 16 2015, 2:06 PM

Committed in r226331. Thanks!