[lld] Remove fragile regex from test

[garious]

Summary

These tests were checking for absolute paths and could fail if it included any valid path character that was not included in that regex. This patch avoids the issue by removing the path checks.

[ruiu]

test/elf/dynamic-undef.test

30 ↗

(On Diff #18048)

I don't fully understand why now you need to split this into two lines. If "Undefined symbol" is not on the same line as "shared.so-x86-64: puts", why the previous test succeeded?

[garious]

test/elf/dynamic-undef.test

30 ↗

(On Diff #18048)

I suspect FileCheck looks for "no more than one newline". How about {{.+[\\/]}} instead?

[ruiu]

test/elf/dynamic-undef.test

30 ↗

(On Diff #18048)

Maybe

EXEC: Undefined symbol: {{.*}}/shared.so-x86-64: puts

is enough?

[garious]

Attempt 2: Use a regex that accepts any set of characters that ends in a [back]slash.

[garious]

test/elf/dynamic-undef.test

30 ↗

(On Diff #18048)

Would that work if cross-compiling on Windows?

lld/trunk/test/elf/dynamic-undef.test

 # Test creation of shared library, this should fail because we are using
 # shared option setting the options to use the shared library undefines to
 # create undefined atoms from the input shared library
 RUN: lld -flavor gnu -target x86_64-linux %p/Inputs/tls.x86-64 \
 RUN:   %p/Inputs/shared.so-x86-64 -o %t.useundefines -e main -shared \
 RUN: --use-shlib-undefines --no-allow-shlib-undefined  2> %t2
 RUN: llvm-readobj -symbols %t.useundefines | FileCheck -check-prefix=SHLIB-UNDEF-SYMBOLS %s
 
-EXEC: Undefined symbol: {{[+-_A-Za-z0-9.\\/:]+}}shared.so-x86-64: puts
-SHLIB: Undefined symbol: {{[+-_A-Za-z0-9.\\/:]+}}shared.so-x86-64: puts
-EXEC-NOT: Undefined symbol: {{[+-_A-Za-z0-9.\\/:]+}}shared.so-x86-64: weakfoo
-SHLIB-NOT: Undefined symbol: {{[+-_A-Za-z0-9.\\/:]+}}shared.so-x86-64: weakfoo
+EXEC: Undefined symbol: {{.+[\\/]}}shared.so-x86-64: puts
+SHLIB: Undefined symbol: {{.+[\\/]}}shared.so-x86-64: puts
+EXEC-NOT: Undefined symbol: {{.+[\\/]}}shared.so-x86-64: weakfoo
+SHLIB-NOT: Undefined symbol: {{.+[\\/]}}shared.so-x86-64: weakfoo
 SHLIB-NOUNDEF-NOT: Name: puts
 SHLIB-UNDEF-SYMBOLS: Name: puts

lld/trunk/test/elf/filenotfound.test

 # Check that a file that cannot be found results in a proper error message
 RUN: not lld -flavor gnu -target x86_64 %p/Inputs/nofile.o 2>&1 | FileCheck %s
-#CHECK: lld: cannot find file {{[+-_A-Za-z0-9.\\/:]+}}nofile.o
+#CHECK: lld: cannot find file {{.+[\\/]}}nofile.o