Page MenuHomePhabricator

Change type of m_step_count to uint_t.
ClosedPublic

Authored by dsinclair on Jan 9 2015, 11:02 AM.

Details

Summary

The CommandObjectThread m_step_count variable is current set as int32_t but when it's assigned, and when it's compared to other things, it's used as a uint32_t. This CL changes the type to match the usage.

Diff Detail

Repository
rL LLVM

Event Timeline

dsinclair updated this revision to Diff 17935.Jan 9 2015, 11:02 AM
dsinclair retitled this revision from to Change type of m_step_count to uint_t..
dsinclair updated this object.
dsinclair edited the test plan for this revision. (Show Details)
dsinclair added a reviewer: jingham.
dsinclair added a subscriber: Unknown Object (MLST).
zturner accepted this revision.Jan 9 2015, 12:01 PM
zturner added a reviewer: zturner.
zturner added a subscriber: zturner.

lgtm, I will commit both of these for you.

In the future specify some value for -U large enough to generate enough context to see the whole file. Like -U999999. Otherwise I have to go look at the source on disk to see all the places where this variable is used and make sure everything looks ok.

This revision is now accepted and ready to land.Jan 9 2015, 12:01 PM
This revision was automatically updated to reflect the committed changes.