Page MenuHomePhabricator

[clang][ifs] Avoid assumption of default visibility in InterfaceStubs tests
ClosedPublic

Authored by JamesNagurne on Oct 11 2019, 4:20 PM.

Details

Summary

In D63978, tests were added which expect that the default visibility is
maintained without an explicit option.

In at least one case, a downstream toolchain had the default
visibility set to 'hidden', which causes these tests to fail.

To avoid such assumptions, we can explicitly pass
-fvisibility=default to the tests that make this assumption.

Diff Detail

Event Timeline

JamesNagurne created this revision.Oct 11 2019, 4:20 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 11 2019, 4:20 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
plotfi accepted this revision.Oct 11 2019, 4:33 PM
This revision is now accepted and ready to land.Oct 11 2019, 4:33 PM

Sadly I'm home from the weekend, so I can't post more diffs for the renaming.
Here's a link to a github search though! I think this would be all the places: https://github.com/llvm/llvm-project/search?q=iterface&unscoped_q=iterface

I nor the rest of my team have the ability to commit, so I need you to do the honors. Thanks!

This revision was automatically updated to reflect the committed changes.