This is an archive of the discontinued LLVM Phabricator instance.

[InlineTest] getRerunArgs returns an empty string if the test was skipped.
ClosedPublic

Authored by sivachandra on Jan 8 2015, 5:23 PM.

Details

Summary

The main issue that this patch is trying to address is that the current
implementation of getRerunArgs of InlineTest relies on the attribute
'using_dsym' which could be absent if the test was skipped altogether.
[That is, if both dsym and dwarf tests were skipped.]

While at it, the use of deprecated Python module 'new' is eliminated.

Diff Detail

Event Timeline

sivachandra updated this revision to Diff 17919.Jan 8 2015, 5:23 PM
sivachandra retitled this revision from to [InlineTest] getRerunArgs returns an empty string if the test was skipped..
sivachandra updated this object.
sivachandra edited the test plan for this revision. (Show Details)
sivachandra added reviewers: clayborg, vharron.
sivachandra added a subscriber: Unknown Object (MLST).
clayborg accepted this revision.Jan 8 2015, 5:48 PM
clayborg edited edge metadata.

Looks good.

This revision is now accepted and ready to land.Jan 8 2015, 5:48 PM
sivachandra closed this revision.Jan 8 2015, 5:55 PM