This is an archive of the discontinued LLVM Phabricator instance.

[go] Teach the go cmake build functions to funnel the include directories down into the cgo-setup variables of llvm-go.
ClosedPublic

Authored by chandlerc on Dec 29 2014, 2:19 PM.

Details

Summary

This in turn allows us to use #includes with cgo that rely on CMake
provided include directories which is particularly useful for handling
generated headers that aren't reasonable to put in an "installable"
location.

Diff Detail

Repository
rL LLVM

Event Timeline

chandlerc updated this revision to Diff 17676.Dec 29 2014, 2:19 PM
chandlerc retitled this revision from to [go] Teach the go cmake build functions to funnel the include directories down into the cgo-setup variables of llvm-go..
chandlerc updated this object.
chandlerc edited the test plan for this revision. (Show Details)
chandlerc added a reviewer: pcc.
chandlerc added a subscriber: Unknown Object (MLST).
pcc added inline comments.Dec 29 2014, 2:39 PM
cmake/modules/AddLLVM.cmake
636 ↗(On Diff #17676)

Are you sure you need to set cxxflags? As far as I know, cppflags should be picked up for C and C++.

pcc accepted this revision.Dec 29 2014, 2:40 PM
pcc edited edge metadata.

(and LGTM once that is resolved)

This revision is now accepted and ready to land.Dec 29 2014, 2:40 PM
This revision was automatically updated to reflect the committed changes.