This is an archive of the discontinued LLVM Phabricator instance.

Make the __morestack function available to the JIT memory manager under Linux.
ClosedPublic

Authored by pcc on Dec 28 2014, 6:07 AM.

Details

Summary

This function's implementation lives in libgcc, a static library, so we need
to expose it explicitly, like the other such functions.

Diff Detail

Repository
rL LLVM

Event Timeline

pcc updated this revision to Diff 17658.Dec 28 2014, 6:07 AM
pcc retitled this revision from to Make the __morestack function available to the JIT memory manager under Linux..
pcc updated this object.
pcc edited the test plan for this revision. (Show Details)
pcc added a subscriber: Unknown Object (MLST).
reames added a subscriber: reames.Dec 29 2014, 12:45 PM

LGTM - If you can, include the appropriate header, but you can submit either way. That's extremely minor.

lib/ExecutionEngine/RTDyldMemoryManager.cpp
215 ↗(On Diff #17658)

Why do we need to forward declare this function, but not the other glibc functions used in getSymbolAddressInProccess? Is there a header we could include instead?

pcc added inline comments.Dec 30 2014, 10:07 AM
lib/ExecutionEngine/RTDyldMemoryManager.cpp
215 ↗(On Diff #17658)

This function has a non-standard calling convention, so as far as I know there is no header we can include.

This revision was automatically updated to reflect the committed changes.