This is an archive of the discontinued LLVM Phabricator instance.

[Sanitizer] Introduce Allocator::may_return_null bool flag.
ClosedPublic

Authored by samsonov on Dec 11 2014, 11:29 AM.

Details

Summary

Turn "allocator_may_return_null" common flag into an
Allocator::may_return_null bool flag. We want to make sure
that common flags are immutable after initialization. There
are cases when we want to change this flag in the allocator
at runtime: e.g. in unit tests and during ASan activation
on Android.

Diff Detail

Event Timeline

samsonov updated this revision to Diff 17184.Dec 11 2014, 11:29 AM
samsonov retitled this revision from to [Sanitizer] Introduce Allocator::may_return_null bool flag..
samsonov updated this object.
samsonov edited the test plan for this revision. (Show Details)
samsonov added reviewers: kcc, eugenis.
samsonov added a subscriber: Unknown Object (MLST).
kcc accepted this revision.Dec 11 2014, 2:48 PM
kcc edited edge metadata.

LGTM
Please try to test this on something other than just the reg tests

This revision is now accepted and ready to land.Dec 11 2014, 2:48 PM
eugenis accepted this revision.Dec 12 2014, 2:15 AM
eugenis edited edge metadata.

LGTM

Ran some more tests, didn't observe any problems. Submitting this now, thanks for the review!

This revision was automatically updated to reflect the committed changes.