Page MenuHomePhabricator

change asan info msg to use debugger output stream instead of adding to module warning collection
ClosedPublic

Authored by jasonmolenda on Dec 8 2014, 5:24 PM.

Details

Reviewers
kubamracek
Summary

When lldb loads a binary that was built -fsanitize=address, it prints an info message via the Module's warning printer; it looks like

warning: (x86_64h) /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/clang/lib/darwin/libclang_rt.asan_osx_dynamic.dylib AddressSanitizer debugger support is active. Memory error breakpoint has been installed and you can now use the 'memory history' command.

Instead, I think we should grab the debugger's output stream and print the message there without the warning/arch/module name. Like

AddressSanitizer debugger support is active. Memory error breakpoint has been installed and you can now use the 'memory history' command.

Diff Detail

Event Timeline

jasonmolenda retitled this revision from to change asan info msg to use debugger output stream instead of adding to module warning collection.
jasonmolenda updated this object.
jasonmolenda edited the test plan for this revision. (Show Details)
jasonmolenda added a reviewer: kubamracek.
jasonmolenda set the repository for this revision to rL LLVM.
jasonmolenda added a subscriber: Unknown Object (MLST).
kubamracek accepted this revision.Dec 9 2014, 10:16 AM
kubamracek edited edge metadata.

Perfect, LGTM, thanks!

This revision is now accepted and ready to land.Dec 9 2014, 10:16 AM
jasonmolenda closed this revision.Dec 9 2014, 12:53 PM

Landed in r223826.