[compiler-rt] Upstreaming small changes from the Rust project.

[vadimcn]

Summary

• Created a macro for const section declarations.

[vadimcn]

Hi,
You guys seem to be the most active in compiler-rt repo. Can you please review and commit? (or suggest somebody more appropriate). Thanks!

[samsonov]

I've submitted permission change to sanitizer_common_interceptors_ioctl.inc in r223715.

Looks like changes to make/platform should also include clang_macho_embedded.mk.

[compnerd]

lib/builtins/assembly.h

45

I'd rather leave this part of the change out. We don't have a good way to test if the target is COFF, which these directives target, not specifically Windows.

make/config.mk

47 ↗

(On Diff #16978)

Whats the reason for sinking the -fPIC into the individual makefiles rather than keeping it here?

[vadimcn]

lib/builtins/assembly.h

45

ok

make/config.mk

47 ↗

(On Diff #16978)

mingw gcc issues a warning for each compiled file: "-fPIC ignored for target (all code is position independent)", which doesn't go well together with -Werror.

On second thought, -fno-PIC seems to override it, so perhaps I'll drop this change and instead add a special case when building for Windows.

[vadimcn]

Dropped "-fPIC" part of the change, dropped #ifdef WIN32_ check.

[compnerd]

Committed as SVN r223910.

Thanks for the patch!

lib/builtins/assembly.h

 // tell linker it can break up file at label boundaries
 #define FILE_LEVEL_DIRECTIVE .subsections_via_symbols
 #define SYMBOL_IS_FUNC(name)
+#define CONST_SECTION .const
 
 #elif defined(__ELF__)
 

 #else
 #define SYMBOL_IS_FUNC(name) .type name,@function
 #endif
+#define CONST_SECTION .section .rodata
 
 #else // !__APPLE__ && !__ELF__
 
-#define HIDDEN_DIRECTIVE(name)
+#define HIDDEN(name)
 #define LOCAL_LABEL(name) .L ## name
 #define FILE_LEVEL_DIRECTIVE
 #define SYMBOL_IS_FUNC(name)                                                   \

     .scl 2 SEPARATOR                                                           \
     .type 32 SEPARATOR                                                         \
   .endef
+#define CONST_SECTION .section .rdata,"rd"
 
 #endif
 

lib/builtins/i386/floatdidf.S

 
 #ifdef __i386__
 
-#if defined(__APPLE__)
-  .const
-#elif defined(__ELF__)
-  .section .rodata
-#else
-  .section .rdata,"rd"
-#endif
+CONST_SECTION
 
   .balign 16
 twop52:

lib/builtins/i386/floatundidf.S

 
 #ifdef __i386__
 
-#if defined(__APPLE__)
-  .const
-#elif defined(__ELF__)
-  .section .rodata
-#else
-  .section .rdata,"rd"
-#endif
+CONST_SECTION
 
   .balign 16
 twop52:

lib/builtins/i386/floatundisf.S

 
 #ifdef __i386__
 
-.const
+CONST_SECTION
 .balign 3
 
     .quad 0x43f0000000000000

 
 #ifdef __i386__
 
-#if defined(__APPLE__)
-  .const
-#elif defined(__ELF__)
-  .section .rodata
-#else
-  .section .rdata,"rd"
-#endif
+CONST_SECTION
 
   .balign 16
 twop52:

lib/builtins/i386/floatundixf.S

 
 #ifdef __i386__
 
-#if defined(__APPLE__)
-  .const
-#elif defined(__ELF__)
-  .section .rodata
-#else
-  .section .rdata,"rd"
-#endif
+CONST_SECTION
 
   .balign 16
 twop52:

lib/builtins/x86_64/floatundidf.S

 
 #ifdef __x86_64__
 
-#if defined(__APPLE__)
-  .const
-#elif defined(__ELF__)
-  .section .rodata
-#else
-  .section .rdata,"rd"
-#endif
+CONST_SECTION
 
   .balign 16
 twop52:

lib/builtins/x86_64/floatundisf.S

 
 #ifdef __x86_64__
 
-#if defined(__APPLE__)
-  .literal4
-#elif defined(__ELF__)
-  .section .rodata
-#else
-  .section .rdata,"rd"
-#endif
+CONST_SECTION
 
   .balign 16
 two:

lib/builtins/x86_64/floatundixf.S

 
 #ifdef __x86_64__
 
-#if defined(__APPLE__)
-  .const
-#elif defined(__ELF__)
-  .section .rodata
-#else
-  .section .rdata,"rd"
-#endif
+CONST_SECTION
 
   .balign 16
 twop64:

 
 #ifdef __x86_64__
 
-#if defined(__APPLE__)
-  .const
-#elif defined(__ELF__)
-  .rdata
-#else
-  .section .rdata,"rd"
-#endif
+CONST_SECTION
+
   .balign 4
 twop52:
   .quad 0x4330000000000000