This is an archive of the discontinued LLVM Phabricator instance.

Add some comments better documenting some fields of RegisterInfo and RegisterSet
Needs ReviewPublic

Authored by zturner on Nov 21 2014, 4:59 PM.

Details

Reviewers
clayborg
Summary

No code change here. Putting this up for review to make sure you agree with the comments as written here.

One question: Will value_regs ever contain more than a single value? Example:

x86-64:
value_regs(ah) = { rax, LLDB_INVALID_REGNUM }
value_regs(al) = { rax, LLDB_INVALID_REGNUM }
value_regs(ax) = { rax, LLDB_INVALID_REGNUM }
value_regs(eax) = { rax, LLDB_INVALID_REGNUM }
value_regs(rax) = nullptr

x86:
value_regs(ah) = { eax, LLDB_INVALID_REGNUM }
value_regs(al) = { eax, LLDB_INVALID_REGNUM }
value_regs(ax) = { eax, LLDB_INVALID_REGNUM }
value_regs(eax) = nullptr

When would value_regs ever contain more than one value?

Diff Detail

Event Timeline

zturner updated this revision to Diff 16521.Nov 21 2014, 4:59 PM
zturner retitled this revision from to Add some comments better documenting some fields of RegisterInfo and RegisterSet.
zturner updated this object.
zturner edited the test plan for this revision. (Show Details)
zturner added a reviewer: clayborg.
zturner added a subscriber: Unknown Object (MLST).