I updated some of the VSX test cases for Power to check fast-isel codegen as well as the regular codegen. For most of them they could be used as-is with just adding a new RUN line.
Diff Detail
Diff Detail
Event Timeline
Comment Actions
So this patch does things I don't know if you're aware of - it turns on fast-isel, but for llc -O2 (the default). I don't know that this is the direction you were wanting to go with this patch, though it's not necessarily bad. It doesn't test the standard -O0 code generation path though.
Comment Actions
I'm fine with adding the extra testing -- feel free to commit. Be aware, however, as Eric said, this is not the same as testing the normal -O0 pipeline.
Comment Actions
Changed the tests to specifically use -O0. I left the -fast-isel option in as well. This resulted in hundreds of additional changed lines in the output.
Comment Actions
Definitely exhaustive. I'll accept your word that the code generation is what you expect :)