This is an archive of the discontinued LLVM Phabricator instance.

Update Power VSX test cases to also test fast-isel
ClosedPublic

Authored by seurer on Nov 21 2014, 11:24 AM.

Details

Summary

I updated some of the VSX test cases for Power to check fast-isel codegen as well as the regular codegen. For most of them they could be used as-is with just adding a new RUN line.

Diff Detail

Event Timeline

seurer updated this revision to Diff 16499.Nov 21 2014, 11:24 AM
seurer retitled this revision from to Update Power VSX test cases to also test fast-isel.
seurer updated this object.
seurer edited the test plan for this revision. (Show Details)
seurer added reviewers: echristo, hfinkel, wschmidt.
seurer added a subscriber: Unknown Object (MLST).
echristo edited edge metadata.Nov 21 2014, 11:49 AM

So this patch does things I don't know if you're aware of - it turns on fast-isel, but for llc -O2 (the default). I don't know that this is the direction you were wanting to go with this patch, though it's not necessarily bad. It doesn't test the standard -O0 code generation path though.

hfinkel accepted this revision.Nov 21 2014, 12:36 PM
hfinkel edited edge metadata.

I'm fine with adding the extra testing -- feel free to commit. Be aware, however, as Eric said, this is not the same as testing the normal -O0 pipeline.

This revision is now accepted and ready to land.Nov 21 2014, 12:36 PM
seurer updated this revision to Diff 16884.Dec 3 2014, 12:49 PM
seurer edited edge metadata.

Changed the tests to specifically use -O0. I left the -fast-isel option in as well. This resulted in hundreds of additional changed lines in the output.

echristo accepted this revision.Dec 3 2014, 1:06 PM
echristo edited edge metadata.

Definitely exhaustive. I'll accept your word that the code generation is what you expect :)

Thanks for doing the work for this. LGTM!

seurer closed this revision.Dec 8 2014, 6:55 AM

Code checked in [llvm] r223509