This is an archive of the discontinued LLVM Phabricator instance.

Remove VariadicOperatorMatcherInterface as it is redundant with logic from DynTypedMatcher.
ClosedPublic

Authored by sbenza on Nov 14 2014, 1:11 PM.

Details

Summary

The generic variadic matcher is faster (one less virtual function call
per match) and doesn't require template instantiations which reduces
compile time and binary size.
Registry.cpp.o generates ~14% less symbols and compiles ~7.5% faster.
The change also speeds up our clang-tidy benchmark by ~2%.

Diff Detail

Event Timeline

sbenza updated this revision to Diff 16247.Nov 14 2014, 1:11 PM
sbenza retitled this revision from to Remove VariadicOperatorMatcherInterface as it is redundant with logic from DynTypedMatcher..
sbenza updated this object.
sbenza edited the test plan for this revision. (Show Details)
sbenza added a reviewer: klimek.
sbenza added a subscriber: Unknown Object (MLST).
klimek accepted this revision.Nov 16 2014, 2:22 AM
klimek edited edge metadata.

Nice! LG

This revision is now accepted and ready to land.Nov 16 2014, 2:22 AM
sbenza closed this revision.Nov 17 2014, 6:56 AM
sbenza updated this revision to Diff 16286.

Closed by commit rL222131 (authored by @sbenza).