This is an archive of the discontinued LLVM Phabricator instance.

Add a helpful assert if LineNo would clobber ArgNo
Needs ReviewPublic

Authored by loladiro on Nov 9 2014, 1:33 PM.

Details

Reviewers
echristo
Summary

Otherwise passing in an invalid line number on accident (e.g. -1)
would cause a hard-to-decipher assert later on. Better to catch this early.

Diff Detail

Event Timeline

loladiro updated this revision to Diff 15962.Nov 9 2014, 1:33 PM
loladiro retitled this revision from to Add a helpful assert if LineNo would clobber ArgNo.
loladiro updated this object.
loladiro edited the test plan for this revision. (Show Details)
loladiro added a reviewer: echristo.
loladiro set the repository for this revision to rL LLVM.
loladiro added a subscriber: Unknown Object (MLST).

I feel slightly silly for bumping this, since it's such a trivial change, but I was looking through my current patch set locally and realized this wasn't in yet.

echristo edited edge metadata.Jan 5 2015, 11:47 AM

I like the idea of degrading since that it's limited to 24 bits is a limitation on our part... that patch is fine to just go in though.