This is an archive of the discontinued LLVM Phabricator instance.

Differential D6080

[asan] [mips] [llvm] changed ShadowOffset32 for systems having 16kb PageSize
ClosedPublic

Authored by sdkie on Nov 3 2014, 3:28 AM.

Details

Reviewers
kcc
petarj
Summary

Earlier ShadowOffset32 address was not aligned to 16kb PageSize
This patch is for LLVM Instrumentation part.
Link for compile-rt patch: http://reviews.llvm.org/D6025

Diff Detail

Event Timeline

sdkie updated this revision to Diff 15686.Nov 3 2014, 3:28 AM
sdkie retitled this revision from to [asan] [mips] [llvm] changed ShadowOffset32 for systems having 16kb PageSize.
sdkie updated this object.
sdkie edited the test plan for this revision. (Show Details)
sdkie added reviewers: kcc, petarj.
sdkie set the repository for this revision to rL LLVM.
sdkie added subscribers: dsanders, mohit.bhakkad, slthakur, Unknown Object (MLST).
kcc accepted this revision.Nov 3 2014, 10:45 AM
kcc edited edge metadata.

LGTM
I will commit this and D6025 shortly.

This revision is now accepted and ready to land.Nov 3 2014, 10:45 AM
kcc closed this revision.Nov 4 2014, 11:57 AM

r221288.

Revision Contents

PathSize
lib/
Transforms/
Instrumentation/
2 lines

Diff 15686

lib/Transforms/Instrumentation/AddressSanitizer.cpp

Show First 20 Lines • Show All 54 Lines • ▼ Show 20 Lines
#define DEBUG_TYPE "asan" #define DEBUG_TYPE "asan"
static const uint64_t kDefaultShadowScale = 3; static const uint64_t kDefaultShadowScale = 3;
static const uint64_t kDefaultShadowOffset32 = 1ULL << 29; static const uint64_t kDefaultShadowOffset32 = 1ULL << 29;
static const uint64_t kIOSShadowOffset32 = 1ULL << 30; static const uint64_t kIOSShadowOffset32 = 1ULL << 30;
static const uint64_t kDefaultShadowOffset64 = 1ULL << 44; static const uint64_t kDefaultShadowOffset64 = 1ULL << 44;
static const uint64_t kSmallX86_64ShadowOffset = 0x7FFF8000; // < 2G. static const uint64_t kSmallX86_64ShadowOffset = 0x7FFF8000; // < 2G.
static const uint64_t kPPC64_ShadowOffset64 = 1ULL << 41; static const uint64_t kPPC64_ShadowOffset64 = 1ULL << 41;
static const uint64_t kMIPS32_ShadowOffset32 = 0x0aaa8000; static const uint64_t kMIPS32_ShadowOffset32 = 0x0aaa0000;
static const uint64_t kFreeBSD_ShadowOffset32 = 1ULL << 30; static const uint64_t kFreeBSD_ShadowOffset32 = 1ULL << 30;
static const uint64_t kFreeBSD_ShadowOffset64 = 1ULL << 46; static const uint64_t kFreeBSD_ShadowOffset64 = 1ULL << 46;
static const size_t kMinStackMallocSize = 1 << 6; // 64B static const size_t kMinStackMallocSize = 1 << 6; // 64B
static const size_t kMaxStackMallocSize = 1 << 16; // 64K static const size_t kMaxStackMallocSize = 1 << 16; // 64K
static const uintptr_t kCurrentStackFrameMagic = 0x41B58AB3; static const uintptr_t kCurrentStackFrameMagic = 0x41B58AB3;
static const uintptr_t kRetiredStackFrameMagic = 0x45E0360E; static const uintptr_t kRetiredStackFrameMagic = 0x45E0360E;
▲ Show 20 Lines • Show All 1,796 Lines • Show Last 20 Lines