This is an archive of the discontinued LLVM Phabricator instance.

[asan] [mips] changed ShadowOffset32 for systems having 16kb PageSize
ClosedPublic

Authored by sdkie on Oct 29 2014, 5:55 AM.

Details

Summary

Earlier ShadowOffset32 address was not aligned to 16kb PageSize
This patch is for compiler-rt project.
The link to corresponding asan Instrumentation part of LLVM - http://reviews.llvm.org/D6080

Diff Detail

Event Timeline

sdkie updated this revision to Diff 15547.Oct 29 2014, 5:55 AM
sdkie retitled this revision from to [asan] [mips] changed ShadowOffset32 for systems having 16kb PageSize.
sdkie updated this object.
sdkie edited the test plan for this revision. (Show Details)
sdkie added reviewers: kcc, petarj, samsonov.
sdkie set the repository for this revision to rL LLVM.
sdkie added subscribers: dsanders, slthakur, mohit.bhakkad, Unknown Object (MLST).
kcc edited edge metadata.Oct 30 2014, 11:10 AM

LGTM

Thanks.
Similar change need to be done in llvm code, I will submit its patch tomorrow.

I don't have commit access, can you please commit it for me.

kcc added a comment.Oct 31 2014, 2:07 PM

I can commit both changes at once, when you have both.
Or ask petarj to commit.

sdkie updated this object.Nov 3 2014, 3:31 AM
sdkie edited edge metadata.
kcc added a comment.Nov 3 2014, 10:48 AM

Ah, wait a moment.
Please also update the comment above these lines:
// Default Linux/MIPS mapping:

You can get the mapping printed by asan-ified program with ASAN_OPTIONS=verbosity=1

sdkie updated this revision to Diff 15747.Nov 4 2014, 12:54 AM

Change "Default Linux/MIPS mapping" as commented by kcc

sdkie updated this revision to Diff 15748.Nov 4 2014, 12:59 AM

increased the patch context using -U999999

kcc accepted this revision.Nov 4 2014, 11:57 AM
kcc edited edge metadata.

r221288.

This revision is now accepted and ready to land.Nov 4 2014, 11:57 AM
kcc closed this revision.Nov 4 2014, 11:57 AM