This is an archive of the discontinued LLVM Phabricator instance.

Shrink the set of checks enabled by default.
ClosedPublic

Authored by alexfh on Oct 29 2014, 10:45 AM.

Download Raw Diff

Details

Reviewers

Commits

rG50ab15654e0f: Shrink the set of checks enabled by default.
rCTE220865: Shrink the set of checks enabled by default.
rL220865: Shrink the set of checks enabled by default.

Summary

Enable only compiler diagnostics and safe static analyzer checks by
default. Let the defaults be conservative and safe for an average project.

Diff Detail

Event Timeline

alexfh updated this revision to Diff 15551.Oct 29 2014, 10:45 AM

alexfh retitled this revision from to Shrink the set of checks enabled by default..

alexfh updated this object.

alexfh edited the test plan for this revision. (Show Details)

alexfh added a reviewer: djasper.

alexfh added a subscriber: Unknown Object (MLST).

Looks good.

This revision is now accepted and ready to land.Oct 29 2014, 11:07 AM

alexfh closed this revision.Oct 29 2014, 11:35 AM

Revision Contents

Path

Size

clang-tidy/

tool/

ClangTidyMain.cpp

9 lines

Diff 15551

clang-tidy/tool/ClangTidyMain.cpp

	Show All 29 Lines
	static cl::extrahelp ClangTidyHelp(			static cl::extrahelp ClangTidyHelp(
	"Configuration files:\n"			"Configuration files:\n"
	" clang-tidy attempts to read configuration for each source file from a\n"			" clang-tidy attempts to read configuration for each source file from a\n"
	" .clang-tidy file located in the closest parent directory of the source\n"			" .clang-tidy file located in the closest parent directory of the source\n"
	" file. If any configuration options have a corresponding command-line\n"			" file. If any configuration options have a corresponding command-line\n"
	" option, command-line option takes precedence. The effective\n"			" option, command-line option takes precedence. The effective\n"
	" configuration can be inspected using -dump-config.\n\n");			" configuration can be inspected using -dump-config.\n\n");

	const char DefaultChecks[] =			const char DefaultChecks[] = // Enable these checks:
	"*," // Enable all checks, except these:			"clang-diagnostic-," // compiler diagnostics
	"-clang-analyzer-alpha*," // Too many false positives.			"clang-analyzer-," // Static Analyzer checks
	"-llvm-include-order," // Not implemented yet.			"-clang-analyzer-alpha"; // but not alpha checks: many false positives
	"-google-*,"; // Doesn't apply to LLVM.

	static cl::opt<std::string>			static cl::opt<std::string>
	Checks("checks", cl::desc("Comma-separated list of globs with optional '-'\n"			Checks("checks", cl::desc("Comma-separated list of globs with optional '-'\n"
	"prefix. Globs are processed in order of appearance\n"			"prefix. Globs are processed in order of appearance\n"
	"in the list. Globs without '-' prefix add checks\n"			"in the list. Globs without '-' prefix add checks\n"
	"with matching names to the set, globs with the '-'\n"			"with matching names to the set, globs with the '-'\n"
	"prefix remove checks with matching names from the\n"			"prefix remove checks with matching names from the\n"
	"set of enabled checks.\n"			"set of enabled checks.\n"
	▲ Show 20 Lines • Show All 271 Lines • Show Last 20 Lines