This is an archive of the discontinued LLVM Phabricator instance.

Differential D5964

[mips] Remove redundant code in RetCC_MipsN. NFC.
ClosedPublic

Authored by dsanders on Oct 24 2014, 3:23 AM.

Details

Reviewers
vmedic
Commits
rG7ed3d6575aff: Merged from r220561:
rG8d69aedbd5de: [mips] Remove redundant code in RetCC_MipsN. NFC.
rL223025: Merged from r220561:
rL220561: [mips] Remove redundant code in RetCC_MipsN. NFC.
Summary

i32 is always promoted to i64 so it no longer makes sense to assign i32 to
registers.

Diff Detail

Event Timeline

dsanders updated this revision to Diff 15392.Oct 24 2014, 3:23 AM
dsanders retitled this revision from to [mips] Remove redundant code in RetCC_MipsN. NFC..
dsanders updated this object.
dsanders edited the test plan for this revision. (Show Details)
dsanders added a reviewer: vmedic.
dsanders added a subscriber: Unknown Object (MLST).
dsanders added a parent revision: D5963: [mips] For N32/N64, structs must be passed in the upper bits of a register..Oct 24 2014, 3:23 AM
vmedic accepted this revision.Oct 24 2014, 5:04 AM
vmedic edited edge metadata.

LGTM

This revision is now accepted and ready to land.Oct 24 2014, 5:04 AM
dsanders closed this revision.Oct 24 2014, 7:00 AM

Revision Contents

PathSize
lib/
Target/
Mips/
3 lines

Diff 15392

lib/Target/Mips/MipsCallingConv.td

Show First 20 Lines • Show All 135 Lines • ▼ Show 20 Linesdef RetCC_MipsN : CallingConv<[
// Aggregate returns are positioned at the lowest address in the slot for // Aggregate returns are positioned at the lowest address in the slot for
// both little and big-endian targets. When passing in registers, this // both little and big-endian targets. When passing in registers, this
// requires that big-endian targets shift the value into the upper bits. // requires that big-endian targets shift the value into the upper bits.
CCIfSubtarget<"isLittle()", CCIfSubtarget<"isLittle()",
CCIfType<[i8, i16, i32, i64], CCIfInReg<CCPromoteToType<i64>>>>, CCIfType<[i8, i16, i32, i64], CCIfInReg<CCPromoteToType<i64>>>>,
CCIfSubtargetNot<"isLittle()", CCIfSubtargetNot<"isLittle()",
CCIfType<[i8, i16, i32, i64], CCIfInReg<CCPromoteToUpperBitsInType<i64>>>>, CCIfType<[i8, i16, i32, i64], CCIfInReg<CCPromoteToUpperBitsInType<i64>>>>,
// i32 are returned in registers V0, V1
CCIfType<[i32], CCAssignToReg<[V0, V1]>>,
// i64 are returned in registers V0_64, V1_64 // i64 are returned in registers V0_64, V1_64
CCIfType<[i64], CCAssignToReg<[V0_64, V1_64]>>, CCIfType<[i64], CCAssignToReg<[V0_64, V1_64]>>,
// f32 are returned in registers F0, F2 // f32 are returned in registers F0, F2
CCIfType<[f32], CCAssignToReg<[F0, F2]>>, CCIfType<[f32], CCAssignToReg<[F0, F2]>>,
// f64 are returned in registers D0, D2 // f64 are returned in registers D0, D2
CCIfType<[f64], CCAssignToReg<[D0_64, D2_64]>> CCIfType<[f64], CCAssignToReg<[D0_64, D2_64]>>
▲ Show 20 Lines • Show All 169 Lines • Show Last 20 Lines