This is an archive of the discontinued LLVM Phabricator instance.

R600/SI: Fix definition for s_cselect_b32
ClosedPublic

Authored by arsenm on Oct 23 2014, 7:11 PM.

Details

Reviewers
arsenm
Summary

These were directly using the old base instruction
class, and specifying the wrong register classes
for operands. The operands can be the other special
inputs besides SGPRs. The op name was also being
directly used for the asm string, so this was printed
without any operands.

Diff Detail

Event Timeline

arsenm updated this revision to Diff 15374.Oct 23 2014, 7:11 PM
arsenm retitled this revision from to R600/SI: Fix definition for s_cselect_b32 .
arsenm updated this object.
arsenm edited the test plan for this revision. (Show Details)
arsenm added a subscriber: Unknown Object (MLST).
arsenm accepted this revision.Nov 13 2014, 12:23 PM
arsenm added a reviewer: arsenm.

r221921

This revision is now accepted and ready to land.Nov 13 2014, 12:23 PM
arsenm closed this revision.Nov 13 2014, 12:24 PM