In post-review of r219442, Rafael pointed out that the comment style of the
newly introduced helper didn't follow LLVM's coding standard. I wanted to
mordernize the whole file, but it seemed too silly to document each of these
simple self-describing functions with the same sentence except for 1 word.
I'm wondering if it's OK to use doxygen's group feature like in the attached
patch, or if repeating "\brief Returns the string for the xxxx parameter of
nullptr if not found." is prefered.
Details
Details
Diff Detail
Diff Detail
- Repository
- rL LLVM
Event Timeline
Comment Actions
LGTM. If someone desperately cares what part of doxygen we use or don't use they'll pipe up :)
-eric