This is an archive of the discontinued LLVM Phabricator instance.

Sort unit test failures by name
ClosedPublic

Authored by vharron on Oct 21 2014, 9:32 PM.

Download Raw Diff

Details

Reviewers

clayborg
sbest

Summary

Running tests on different platforms or with different numbers of threads can result in different sorting for the same set of failures. This makes comparing failures more difficult. This patch sorts test failures by test name.

Diff Detail

Event Timeline

vharron updated this revision to Diff 15231.Oct 21 2014, 9:32 PM

vharron retitled this revision from to Sort unit test failures by name.

vharron updated this object.

vharron edited the test plan for this revision. (Show Details)

vharron added a reviewer: clayborg.

vharron added a subscriber: Unknown Object (MLST).

Looks good.

This revision is now accepted and ready to land.Oct 22 2014, 10:00 AM

Shawn, can you submit?

Done, landed in r220406

vharron closed this revision.Nov 19 2014, 2:03 PM

Revision Contents

Path

Size

test/

dosep.py

1 line

Diff 15231

test/dosep.py

Context not available.

	print "Ran %d tests." % num_tests	print "Ran %d tests." % num_tests
	if len(failed) > 0:	if len(failed) > 0:
		failed.sort()
	print "Failing Tests (%d)" % len(failed)	print "Failing Tests (%d)" % len(failed)
	for f in failed:	for f in failed:
	print "FAIL: LLDB (suite) :: %s (%s)" % (f, system_info)	print "FAIL: LLDB (suite) :: %s (%s)" % (f, system_info)
Context not available.