Page MenuHomePhabricator

sbest (Shawn Best)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 10 2014, 3:51 PM (370 w, 6 d)

Recent Activity

Nov 20 2014

sbest closed D5837: fix Bug21211 : reworked test/api/multithreaded/test_listener_event_description.cpp to work properly on Linux/FreeBSD.

Closed by commit rL222511 (authored by @sbest).

Nov 20 2014, 10:50 PM

Nov 14 2014

sbest added a comment to D5837: fix Bug21211 : reworked test/api/multithreaded/test_listener_event_description.cpp to work properly on Linux/FreeBSD.

friendly ping. I was waiting until the other change (D5838 ENABLE_STD_THREADS) landed and I could run the tests in api/multithreaded again. This is a rework of the test program logic to accommodate the fact that OSx and linux broadcast a different sequence of public events due to their different inferior launching.

Nov 14 2014, 4:39 PM
sbest closed D5838: remove CREATE_THREADS:=yes from api/multithreaded Makefile.

Closed by commit rL222031 (authored by @sbest).

Nov 14 2014, 11:42 AM

Nov 13 2014

sbest updated the diff for D5838: remove CREATE_THREADS:=yes from api/multithreaded Makefile.

I have added another flag to test/Makefile.rules ENABLE_STD_THREADS and used it the api/Multithreaded unit tests. This can be used to selectively omit '-lpthreads' option for certain systems. All platforms except linux/gcc should behave as before.

Nov 13 2014, 6:42 PM

Nov 7 2014

sbest retitled D6177: R220718 broke some unit tests on linux from to R220718 broke some unit tests on linux.
Nov 7 2014, 3:58 PM

Nov 6 2014

sbest added a comment to D6127: Fix code formatting in lldbtest.py introduced with r220583..

I can do it

Nov 6 2014, 9:44 AM

Nov 4 2014

sbest added a comment to D6122: Fix compilation of DataFormatters/StringPrinter.cpp with GCC..

Builds and runs fine on OSX/clang as well as Linux/gcc. I will go ahead
and commit.

Nov 4 2014, 2:42 PM

Oct 31 2014

sbest retitled D6066: TOT broken by R220956 from to TOT broken by R220956.
Oct 31 2014, 3:17 PM

Oct 30 2014

sbest added a comment to D6042: Fix junk content handling within GDBRemoteCommunication::CheckForPacket..

Hey Oleksiy, can you rebase the patch for me, I got HUNK Failed when applying. It could be related to the whitespace stripping you did for Greg. Also, I notice something weird with the block of code you wrapped with the while() loop. It appears to be indented only 2 spaces instead of 4.

Oct 30 2014, 6:24 PM

Oct 22 2014

sbest added a comment to D5904: Sort unit test failures by name.

Done, landed in r220406

Oct 22 2014, 12:43 PM

Oct 16 2014

sbest retitled D5838: remove CREATE_THREADS:=yes from api/multithreaded Makefile from to remove CREATE_THREADS:=yes from api/multithreaded Makefile.
Oct 16 2014, 9:02 PM
sbest retitled D5837: fix Bug21211 : reworked test/api/multithreaded/test_listener_event_description.cpp to work properly on Linux/FreeBSD from to fix Bug21211 : reworked test/api/multithreaded/test_listener_event_description.cpp to work properly on Linux/FreeBSD.
Oct 16 2014, 8:29 PM

Oct 8 2014

sbest added a comment to D5632: spurious output to command line when launching a process on linux.

I have done some digging into the failing test and isolated it to a simple C++ program. Basically the test is using the c++ api to lldb:

Oct 8 2014, 8:31 PM
sbest added a comment to D5632: spurious output to command line when launching a process on linux.

I will look into this right now...

Oct 8 2014, 11:26 AM

Oct 6 2014

sbest retitled D5632: spurious output to command line when launching a process on linux from to spurious output to command line when launching a process on linux.
Oct 6 2014, 2:18 PM

Sep 24 2014

sbest retitled D5486: Moved PlatformDarwin::GetEnvironment() to PlatformPOSIX from to Moved PlatformDarwin::GetEnvironment() to PlatformPOSIX.
Sep 24 2014, 3:58 PM

Sep 12 2014

sbest updated the diff for D5302: use std::atomic<> to protect variables being accessed by multiple threads.

Hi Jim, thanks for the feedback.

Sep 12 2014, 11:14 AM

Sep 10 2014

sbest added a reviewer for D5302: use std::atomic<> to protect variables being accessed by multiple threads: tfiala.
Sep 10 2014, 4:39 PM
sbest retitled D5302: use std::atomic<> to protect variables being accessed by multiple threads from to use std::atomic<> to protect variables being accessed by multiple threads.
Sep 10 2014, 4:38 PM