This is an archive of the discontinued LLVM Phabricator instance.

R600: Fix assert on empty function
ClosedPublic

Authored by arsenm on Oct 21 2014, 9:08 PM.

Reviewers

Summary

If a function is just an unreachable, this would hit a
"this is not a MachO target" assertion because of setting
HasSubsectionViaSymbols.

arsenm retitled this revision from to R600: Fix assert on empty function .

arsenm updated this object.

arsenm edited the test plan for this revision. (Show Details)

arsenm added a subscriber: Unknown Object (MLST).

r221920

This revision is now accepted and ready to land.Nov 13 2014, 12:08 PM

Path

Size

lib/

Target/

R600/

MCTargetDesc/

1 line

test/

CodeGen/

R600/

20 lines

Context not available.
	AMDGPUMCAsmInfo::AMDGPUMCAsmInfo(StringRef &TT) : MCAsmInfoELF() {	AMDGPUMCAsmInfo::AMDGPUMCAsmInfo(StringRef &TT) : MCAsmInfoELF() {
	HasSingleParameterDotFile = false;	HasSingleParameterDotFile = false;
	//===------------------------------------------------------------------===//	//===------------------------------------------------------------------===//
	HasSubsectionsViaSymbols = true;
	MaxInstLength = 16;	MaxInstLength = 16;
	SeparatorString = "\n";	SeparatorString = "\n";
	CommentString = ";";	CommentString = ";";
Context not available.

				; RUN: llc -march=r600 -mcpu=SI -verify-machineinstrs < %s \| FileCheck -check-prefix=SI %s

				; Make sure we don't assert on empty functions

				; SI-LABEL: {{^}}empty_function_ret:
				; SI: .text
				; SI: S_ENDPGM
				; SI: codeLenInByte = 4
				define void @empty_function_ret() #0 {
				ret void
				}

				; SI-LABEL: {{^}}empty_function_unreachable:
				; SI: .text
				; SI: codeLenInByte = 0
				define void @empty_function_unreachable() #0 {
				unreachable
				}

				attributes #0 = { nounwind }